From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>, "Theodore Ts'o" <tytso@mit.edu>
Cc: linux-kernel@vger.kernel.org, reiserfs-dev@namesys.com
Subject: [-mm patch] reiserfs: warn about the useless nolargeio option
Date: Thu, 6 Jul 2006 22:37:28 +0200 [thread overview]
Message-ID: <20060706203728.GR26941@stusta.de> (raw)
In-Reply-To: <20060703030355.420c7155.akpm@osdl.org>
On Mon, Jul 03, 2006 at 03:03:55AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.17-mm5:
>...
> +inode-diet-eliminate-i_blksize-and-use-a-per-superblock-default.patch
>...
> Misc updates.
>...
Since the nolargeio option no longer has any effect, print a warning
instead of setting a write-only variable.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
fs/reiserfs/super.c | 21 ++-------------------
1 file changed, 2 insertions(+), 19 deletions(-)
--- linux-2.6.17-mm6-full/fs/reiserfs/super.c.old 2006-07-06 21:48:48.000000000 +0200
+++ linux-2.6.17-mm6-full/fs/reiserfs/super.c 2006-07-06 21:51:48.000000000 +0200
@@ -721,12 +721,6 @@
{NULL, 0, 0},
};
-int reiserfs_default_io_size = 128 * 1024; /* Default recommended I/O size is 128k.
- There might be broken applications that are
- confused by this. Use nolargeio mount option
- to get usual i/o size = PAGE_SIZE.
- */
-
/* proceed only one option from a list *cur - string containing of mount options
opts - array of options which are accepted
opt_arg - if option is found and requires an argument and if it is specifed
@@ -955,19 +949,8 @@
}
if (c == 'w') {
- char *p = NULL;
- int val = simple_strtoul(arg, &p, 0);
-
- if (*p != '\0') {
- reiserfs_warning(s,
- "reiserfs_parse_options: non-numeric value %s for nolargeio option",
- arg);
- return 0;
- }
- if (val)
- reiserfs_default_io_size = PAGE_SIZE;
- else
- reiserfs_default_io_size = 128 * 1024;
+ reiserfs_warning(s, "reiserfs: nolargeio option is no longer supported");
+ return 0;
}
if (c == 'j') {
next prev parent reply other threads:[~2006-07-06 20:38 UTC|newest]
Thread overview: 128+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-03 10:03 2.6.17-mm6 Andrew Morton
2006-07-03 10:50 ` 2.6.17-mm6 Michal Piotrowski
2006-07-03 10:56 ` 2.6.17-mm6 Andrew Morton
2006-07-03 11:36 ` 2.6.17-mm6 Michal Piotrowski
2006-07-03 12:27 ` 2.6.17-mm6 Michal Piotrowski
2006-07-03 13:28 ` 2.6.17-mm6 Dmitry Torokhov
2006-07-03 11:00 ` 2.6.17-mm6 Reuben Farrelly
2006-07-03 11:25 ` 2.6.17-mm6 Andrew Morton
2006-07-03 12:34 ` 2.6.17-mm6 Reuben Farrelly
2006-07-03 11:39 ` 2.6.17-mm6 Andrew Morton
2006-07-03 11:41 ` 2.6.17-mm6 Reuben Farrelly
2006-07-03 12:10 ` 2.6.17-mm6 Andrew Morton
2006-07-03 13:36 ` 2.6.17-mm6 Reuben Farrelly
2006-07-03 20:21 ` 2.6.17-mm6 Andrew Morton
2006-07-03 20:31 ` 2.6.17-mm6 Reuben Farrelly
2006-07-03 12:29 ` 2.6.17-mm6 Sergey Vlasov
2006-07-03 17:25 ` 2.6.17-mm6 Jeremy Fitzhardinge
2006-07-03 19:01 ` 2.6.17-mm6 Andrew Morton
2006-07-03 12:15 ` 2.6.17-mm6 Cedric Le Goater
2006-07-03 12:17 ` 2.6.17-mm6 Heiko Carstens
2006-07-03 13:08 ` 2.6.17-mm6 Martin Peschke
2006-07-03 13:12 ` 2.6.17-mm6 Cedric Le Goater
2006-07-03 12:15 ` 2.6.17-mm6 Cedric Le Goater
2006-07-03 14:09 ` 2.6.17-mm6 Theodore Tso
2006-07-03 19:07 ` 2.6.17-mm6 Alistair John Strachan
2006-07-03 19:37 ` 2.6.17-mm6 Andrew Morton
2006-07-03 19:43 ` 2.6.17-mm6 Alistair John Strachan
2006-07-03 19:27 ` 2.6.17-mm6 Alistair John Strachan
2006-07-03 19:39 ` 2.6.17-mm6 Andrew Morton
2006-07-03 19:56 ` 2.6.17-mm6 Alistair John Strachan
2006-07-03 20:17 ` 2.6.17-mm6 Andrew Morton
2006-07-03 20:36 ` 2.6.17-mm6 Alistair John Strachan
2006-07-03 20:54 ` 2.6.17-mm6 Andrew Morton
2006-07-03 21:50 ` 2.6.17-mm6 Alistair John Strachan
2006-07-03 23:31 ` 2.6.17-mm6 Andrew Morton
2006-07-04 8:34 ` 2.6.17-mm6 Alistair John Strachan
2006-07-04 8:49 ` 2.6.17-mm6 Andrew Morton
2006-07-04 16:28 ` 2.6.17-mm6 Alistair John Strachan
2006-07-05 20:37 ` 2.6.17-mm6 john stultz
2006-07-05 20:46 ` 2.6.17-mm6 Greg KH
2006-07-05 22:32 ` 2.6.17-mm6 Alistair John Strachan
2006-07-06 17:31 ` 2.6.17-mm6 john stultz
2006-07-06 19:06 ` 2.6.17-mm6 Alistair John Strachan
2006-07-06 19:16 ` 2.6.17-mm6 Alistair John Strachan
2006-07-06 20:02 ` 2.6.17-mm6 Alistair John Strachan
2006-07-06 20:11 ` 2.6.17-mm6 Greg KH
2006-07-07 20:48 ` 2.6.17-mm6 Alistair John Strachan
2006-07-08 16:02 ` 2.6.17-mm6 Alistair John Strachan
2006-07-03 22:10 ` 2.6.17-mm6 Anton Blanchard
2006-07-04 19:53 ` 2.6.17-mm6 Rafael J. Wysocki
2006-07-04 20:01 ` 2.6.17-mm6 Arjan van de Ven
2006-07-05 10:27 ` 2.6.17-mm6 Stefan Richter
2006-07-05 10:36 ` 2.6.17-mm6 Stefan Richter
2006-07-05 11:13 ` 2.6.17-mm6 Ingo Molnar
2006-07-05 21:43 ` 2.6.17-mm6 J.A. Magallón
2006-07-05 22:56 ` 2.6.17-mm6 Andrew Morton
2006-07-05 23:57 ` 2.6.17-mm6 J.A. Magallón
2006-07-06 0:02 ` 2.6.17-mm6 Andrew Morton
2006-07-06 14:36 ` 2.6.17-mm6 J.A. Magallón
2006-07-06 14:48 ` 2.6.17-mm6 J.A. Magallón
2006-07-06 21:44 ` 2.6.17-mm6 J.A. Magallón
2006-07-06 21:57 ` 2.6.17-mm6 Andrew Morton
2006-07-07 15:38 ` 2.6.17-mm6 J.A. Magallón
2006-07-07 16:02 ` 2.6.17-mm6 Alan Cox
2006-07-07 15:55 ` 2.6.17-mm6 J.A. Magallón
2006-07-07 16:44 ` 2.6.17-mm6 Alan Cox
2006-07-07 16:34 ` 2.6.17-mm6 Randy.Dunlap
2006-07-07 17:09 ` 2.6.17-mm6 Alan Cox
2006-07-07 17:14 ` 2.6.17-mm6 Jeff Garzik
2006-07-07 17:22 ` 2.6.17-mm6 David Lloyd
2006-07-07 17:23 ` 2.6.17-mm6 Jeff Garzik
2006-07-07 17:44 ` 2.6.17-mm6 Alan Cox
2006-07-07 17:39 ` 2.6.17-mm6 Jeff Garzik
2006-07-07 20:03 ` 2.6.17-mm6 Alan Cox
2006-07-07 19:59 ` 2.6.17-mm6 Jeff Garzik
2006-07-07 20:23 ` 2.6.17-mm6 Alan Cox
2006-07-07 20:14 ` 2.6.17-mm6 Jeff Garzik
2006-07-07 20:42 ` 2.6.17-mm6 Alan Cox
2006-07-07 20:37 ` 2.6.17-mm6 Jeff Garzik
2006-07-07 21:09 ` 2.6.17-mm6 J.A. Magallón
2006-07-07 21:11 ` 2.6.17-mm6 Jeff Garzik
2006-07-07 21:40 ` 2.6.17-mm6 J.A. Magallón
2006-07-06 23:26 ` 2.6.17-mm6 (try-3) Randy.Dunlap
[not found] ` <a762e240607051447x3c3c6e15k9cdb38804cf13f35@mail.gmail.com>
2006-07-05 22:50 ` 2.6.17-mm6 Andrew Morton
2006-07-05 23:28 ` 2.6.17-mm6 Keith Mannthey
2006-07-05 23:44 ` 2.6.17-mm6 Andrew Morton
2006-07-05 23:48 ` 2.6.17-mm6 Andrew Morton
2006-07-06 0:05 ` 2.6.17-mm6 Keith Mannthey
2006-07-06 0:25 ` 2.6.17-mm6 Andrew Morton
2006-07-06 5:42 ` 2.6.17-mm6 Eric W. Biederman
2006-07-06 5:59 ` 2.6.17-mm6 Andrew Morton
2006-07-06 6:31 ` 2.6.17-mm6 Andrew Morton
2006-07-06 7:18 ` 2.6.17-mm6 Eric W. Biederman
2006-07-06 7:25 ` 2.6.17-mm6 Ingo Molnar
2006-07-06 8:21 ` 2.6.17-mm6 Eric W. Biederman
2006-07-06 8:26 ` 2.6.17-mm6 Ingo Molnar
2006-07-06 7:31 ` 2.6.17-mm6 Arjan van de Ven
2006-07-06 16:37 ` 2.6.17-mm6 Valdis.Kletnieks
2006-07-06 16:49 ` 2.6.17-mm6 Eric W. Biederman
2006-07-06 6:40 ` 2.6.17-mm6 Eric W. Biederman
2006-07-06 7:38 ` 2.6.17-mm6 vmstat breakage Mike Galbraith
2006-07-06 8:24 ` Andrew Morton
2006-07-06 17:16 ` 2.6.17-mm6 Andi Kleen
2006-07-12 3:55 ` 2.6.17-mm6 Steven Rostedt
2006-07-06 20:36 ` [-mm patch] drivers/edac/: make code static Adrian Bunk
2006-07-06 20:37 ` [Ocfs2-devel] [-mm patch] fs/ocfs2/inode.c:ocfs2_refresh_inode(): remove unused variable Adrian Bunk
2006-07-06 20:37 ` Adrian Bunk
2006-07-06 20:43 ` [Ocfs2-devel] " Mark Fasheh
2006-07-06 20:43 ` Mark Fasheh
2006-07-06 20:37 ` Adrian Bunk [this message]
2006-07-07 0:35 ` [-mm patch] reiserfs: warn about the useless nolargeio option Hans Reiser
2006-07-06 20:37 ` [-mm patch] drivers/net/e1000/: possible cleanups Adrian Bunk
2006-07-06 20:47 ` Auke Kok
2006-07-07 7:35 ` Adrian Bunk
2006-07-07 9:17 ` 2.6.17-mm6 Reuben Farrelly
2006-07-07 9:35 ` 2.6.17-mm6 Andrew Morton
2006-07-07 21:15 ` 2.6.17-mm6 Reuben Farrelly
2006-07-07 21:38 ` 2.6.17-mm6 Andrew Morton
2006-07-07 21:42 ` 2.6.17-mm6 Martin Bligh
2006-07-07 23:06 ` 2.6.17-mm6 Andrew Morton
2006-07-08 3:46 ` 2.6.17-mm6 Badari Pulavarty
2006-07-07 23:08 ` 2.6.17-mm6 Reuben Farrelly
2006-07-07 15:24 ` 2.6.17-mm6 Reuben Farrelly
2006-07-08 20:20 ` 2.6.17-mm6: kernel/sysctl.c: PROC_FS=n compile error Adrian Bunk
2006-07-09 18:52 ` Serge E. Hallyn
2006-07-09 23:33 ` Adrian Bunk
2006-07-10 14:22 ` Serge E. Hallyn
2006-07-10 15:08 ` Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060706203728.GR26941@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-dev@namesys.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.