All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Tuttle <thinkinginbinary@gmail.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Integrate asus_acpi LED's with new LED subsystem
Date: Thu, 6 Jul 2006 21:44:28 -0400	[thread overview]
Message-ID: <20060707014428.GC8900@phoenix> (raw)
In-Reply-To: <20060706235020.GA4821@elf.ucw.cz>

[-- Attachment #1: Type: text/plain, Size: 833 bytes --]

On July 06 at 19:50 EDT, Pavel Machek hastily scribbled:
> Apart from codingstyle issues...

I've fixed a bunch that Andrew Morton and Richard Purdie mentioned
(since your message, I've posted a new revision).  Are there any changes
I missed?

> yes, it looks good.

Nice. :-)

> Hooking various
> leds into led subsystem is way better than having all the separate
> drivers.

Yes.  The LED subsystem is a really cool idea, because what good are
blinkenlights if you have to write shell scripts to control them?  The
kernel should do that for you!  (/me wishes someone made a laptop with
something like 8 LED's of different colors, so he could just make them
do what he liked.)

> I guess I'll have to convert ibm_acpi...

I'm willing to take a first whack at it, if you can put me in touch with
someone to test it.

--Thomas Tuttle

[-- Attachment #2: Type: application/pgp-signature, Size: 191 bytes --]

  reply	other threads:[~2006-07-07  1:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-06 19:31 [PATCH] Integrate asus_acpi LED's with new LED subsystem Thomas Tuttle
2006-07-06 22:39 ` Richard Purdie
2006-07-07  1:11   ` Thomas Tuttle
2006-07-06 22:49 ` Andrew Morton
2006-07-07  1:20   ` Thomas Tuttle
2006-07-07  8:46     ` Richard Purdie
2006-07-24 21:24     ` Johannes Engel
2006-07-06 23:50 ` Pavel Machek
2006-07-07  1:44   ` Thomas Tuttle [this message]
2006-07-07  9:38     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060707014428.GC8900@phoenix \
    --to=thinkinginbinary@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.