From: Pavel Machek <pavel@ucw.cz>
To: Richard Purdie <rpurdie@rpsys.net>
Cc: lenz@cs.wisc.edu, kernel list <linux-kernel@vger.kernel.org>,
Russell King <rmk+lkml@arm.linux.org.uk>
Subject: Re: [patch] sharpsl_pm refactor
Date: Fri, 7 Jul 2006 14:01:48 +0000 [thread overview]
Message-ID: <20060707140148.GB4239@ucw.cz> (raw)
In-Reply-To: <1152274600.5548.67.camel@localhost.localdomain>
Hi!
> > This prepares sharpsl_pm.c for collie. Without nested if()s, #ifdefs
> > can be added.
>
> I'm unconvinced as to why collie needs an ifdef in there and looking at
> what I think you're leading to, its ugly. Perhaps you could change the 2
> to a variable set by the machine instead or something, depending upon
> your intention.
Well, I hate the if/else maze -- IMO returns are more readable. Anyway
collie needs both count and time checks disabled, AFAICT.
> Rather than post these patches straight to the patch system, perhaps you
> could also post them for discussion first as discussing them once
> they're submitted seems wrong (and we have to remember to remove the
> patch system from the cc).
Sorry about that. Yep, I'm used to work with akpm...
Pavel
--
Thanks for all the (sleeping) penguins.
next prev parent reply other threads:[~2006-07-07 14:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-07 11:48 [patch] sharpsl_pm refactor Pavel Machek
2006-07-07 12:16 ` Richard Purdie
2006-07-07 14:01 ` Pavel Machek [this message]
2006-07-07 15:24 ` Richard Purdie
2006-07-08 13:00 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060707140148.GB4239@ucw.cz \
--to=pavel@ucw.cz \
--cc=lenz@cs.wisc.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.