From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: [RFC: 2.6 patch] remove kernel/kthread.c:kthread_stop_sem()
Date: Fri, 7 Jul 2006 22:45:41 +0200 [thread overview]
Message-ID: <20060707204541.GD26941@stusta.de> (raw)
This patch moves the otherwise unused kthread_stop_sem() into
kthread_stop().
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 29 Jun 2006
include/linux/kthread.h | 12 ------------
kernel/kthread.c | 14 ++------------
2 files changed, 2 insertions(+), 24 deletions(-)
--- linux-2.6.17-mm4-full/include/linux/kthread.h.old 2006-06-29 19:07:40.000000000 +0200
+++ linux-2.6.17-mm4-full/include/linux/kthread.h 2006-06-29 19:07:49.000000000 +0200
@@ -28,7 +28,6 @@
void kthread_bind(struct task_struct *k, unsigned int cpu);
int kthread_stop(struct task_struct *k);
-int kthread_stop_sem(struct task_struct *k, struct semaphore *s);
int kthread_should_stop(void);
#endif /* _LINUX_KTHREAD_H */
--- linux-2.6.17-mm4-full/kernel/kthread.c.old 2006-06-29 19:08:00.000000000 +0200
+++ linux-2.6.17-mm4-full/kernel/kthread.c 2006-06-29 19:08:22.000000000 +0200
@@ -216,23 +216,6 @@
*/
int kthread_stop(struct task_struct *k)
{
- return kthread_stop_sem(k, NULL);
-}
-EXPORT_SYMBOL(kthread_stop);
-
-/**
- * kthread_stop_sem - stop a thread created by kthread_create().
- * @k: thread created by kthread_create().
- * @s: semaphore that @k waits on while idle.
- *
- * Does essentially the same thing as kthread_stop() above, but wakes
- * @k by calling up(@s).
- *
- * Returns the result of threadfn(), or %-EINTR if wake_up_process()
- * was never called.
- */
-int kthread_stop_sem(struct task_struct *k, struct semaphore *s)
-{
int ret;
mutex_lock(&kthread_stop_lock);
@@ -246,10 +229,7 @@
/* Now set kthread_should_stop() to true, and wake it up. */
kthread_stop_info.k = k;
- if (s)
- up(s);
- else
- wake_up_process(k);
+ wake_up_process(k);
put_task_struct(k);
/* Once it dies, reset stop ptr, gather result and we're done. */
@@ -260,7 +240,7 @@
return ret;
}
-EXPORT_SYMBOL(kthread_stop_sem);
+EXPORT_SYMBOL(kthread_stop);
static __init int helper_init(void)
{
next reply other threads:[~2006-07-07 20:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-07 20:45 Adrian Bunk [this message]
2006-07-07 20:58 ` [RFC: 2.6 patch] remove kernel/kthread.c:kthread_stop_sem() Andrew Morton
2006-07-07 21:00 ` Alan Stern
-- strict thread matches above, loose matches on Subject: below --
2006-06-29 19:21 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060707204541.GD26941@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.