From: Michael Hanselmann <linux-kernel@hansmi.ch>
To: Aristeu Sergio Rozanski Filho <aris@valeta.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powermac: defer work in backlight key press
Date: Sat, 8 Jul 2006 16:35:30 +0200 [thread overview]
Message-ID: <20060708143530.GA26186@hansmi.ch> (raw)
In-Reply-To: <20060704013923.GG27596@cathedrallabs.org>
On Mon, Jul 03, 2006 at 10:39:23PM -0300, Aristeu Sergio Rozanski Filho wrote:
> powermac: defer work in backlight key press
> pmac_backlight_key() is called under interrupt context, can't use mutexes or
> semaphores, so defer the backlight level for later, as it's not critical
Nack, needs spinlock around this part:
> + pmac_backlight_key_queued = direction;
> + schedule_work(&pmac_backlight_key_work);
I'll submit another patch with more fixes soon.
Greets,
Michael
next prev parent reply other threads:[~2006-07-08 14:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-04 1:39 [PATCH] powermac: defer work in backlight key press Aristeu Sergio Rozanski Filho
2006-07-04 8:06 ` Johannes Berg
2006-07-04 11:03 ` Aristeu Sergio Rozanski Filho
2006-07-04 11:16 ` Johannes Berg
2006-07-08 14:35 ` Michael Hanselmann [this message]
2006-07-08 15:58 ` [PATCH] powermac: defer work in backlight key press (and export fixes) Michael Hanselmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060708143530.GA26186@hansmi.ch \
--to=linux-kernel@hansmi.ch \
--cc=aris@valeta.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.