From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Brian Walsh <brian@walsh.ws>
Cc: Deepak Sanexa <dsanexa@mvista.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.18-rc1 1/1] mtd/maps: ixp4xx partition parsing
Date: Mon, 10 Jul 2006 21:02:12 +0100 [thread overview]
Message-ID: <20060710200212.GA31761@flint.arm.linux.org.uk> (raw)
In-Reply-To: <44B2AFFB.2070507@walsh.ws>
On Mon, Jul 10, 2006 at 03:52:27PM -0400, Brian Walsh wrote:
> If the amount of flash is not divisible by 2 then the mask in
> parse_mtd_partitions would fail to work as designed. Passing in the
> base address corrects this problem.
This patch is obviously buggy and untested. "resouce" is a typo.
> diff -ur a/drivers/mtd/maps/ixp4xx.c b/drivers/mtd/maps/ixp4xx.c
> --- a/drivers/mtd/maps/ixp4xx.c 2006-06-17 21:49:35.000000000 -0400
> +++ b/drivers/mtd/maps/ixp4xx.c 2006-07-10 13:34:09.000000000 -0400
> @@ -253,7 +253,7 @@
> /* Use the fast version */
> info->map.write = ixp4xx_write16,
>
> - err = parse_mtd_partitions(info->mtd, probes, &info->partitions, 0);
> + err = parse_mtd_partitions(info->mtd, probes, &info->partitions,
> dev->resouce->start);
> if (err > 0) {
> err = add_mtd_partitions(info->mtd, info->partitions, err);
> if(err)
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2006-07-10 20:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-10 19:52 [PATCH 2.6.18-rc1 1/1] mtd/maps: ixp4xx partition parsing Brian Walsh
2006-07-10 20:02 ` Russell King [this message]
2006-07-10 20:40 ` Brian Walsh
2006-07-10 20:46 ` [PATCH 2.6.18-rc1 1/1] [RESUBMIT] " Brian Walsh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060710200212.GA31761@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=brian@walsh.ws \
--cc=dsanexa@mvista.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.