From: Daniel Jacobowitz <dan@debian.org>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: macro@linux-mips.org, linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: [PATCH] fast path for rdhwr emulation for TLS
Date: Mon, 10 Jul 2006 22:53:42 -0400 [thread overview]
Message-ID: <20060711025342.GA6898@nevyn.them.org> (raw)
In-Reply-To: <20060710.235553.48797818.anemo@mba.ocn.ne.jp>
On Mon, Jul 10, 2006 at 11:55:53PM +0900, Atsushi Nemoto wrote:
> On Fri, 7 Jul 2006 17:58:44 +0100 (BST), "Maciej W. Rozycki" <macro@linux-mips.org> wrote:
> > mfc0 k0, CP0_CAUSE
> > MFC0 k1, CP0_EPC
> > bltz k0, handle_ri_slow /* if delay slot */
> > lui k0, 0x7c03
>
> I noticed that checking for CP0_CAUSE.BD is unneeded, since we are
> checking the instruction code anyway and "rdhwr" does not have a delay
> slot. I removed the checking on the "take 2" patch I just sent.
Isn't BD "this instruction is in a delay slot", not "this instruction
has a delay slot"? It affects where we go when we return.
BTW, if the fast emulation can't handle rdhwr in a delay slot, please
report a bug on GCC asking it not to put rdhwr in delay slots by
default. It's probably worthwhile.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-07-11 2:53 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-07 15:00 [PATCH] fast path for rdhwr emulation for TLS Atsushi Nemoto
2006-07-07 15:22 ` Maciej W. Rozycki
2006-07-07 16:12 ` Atsushi Nemoto
2006-07-07 16:43 ` Atsushi Nemoto
2006-07-07 17:04 ` Maciej W. Rozycki
2006-07-07 18:22 ` Ralf Baechle
2006-07-07 16:58 ` Maciej W. Rozycki
2006-07-08 16:12 ` Atsushi Nemoto
2006-07-10 14:40 ` Atsushi Nemoto
2006-09-14 17:28 ` Ralf Baechle
2006-09-15 3:09 ` Atsushi Nemoto
2006-07-10 14:55 ` Atsushi Nemoto
2006-07-11 2:53 ` Daniel Jacobowitz [this message]
2006-07-11 3:20 ` Atsushi Nemoto
2006-09-08 17:39 ` Nigel Stephens
2006-09-09 13:56 ` Atsushi Nemoto
2006-09-10 22:30 ` Nigel Stephens
2006-09-11 5:04 ` Atsushi Nemoto
2006-09-11 8:50 ` Atsushi Nemoto
2006-09-11 9:49 ` Thiemo Seufer
2006-09-11 14:13 ` Atsushi Nemoto
2006-09-11 15:17 ` Thiemo Seufer
2006-09-11 13:09 ` Maciej W. Rozycki
2006-09-11 14:30 ` Atsushi Nemoto
2006-09-11 17:53 ` Maciej W. Rozycki
2006-09-12 1:55 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060711025342.GA6898@nevyn.them.org \
--to=dan@debian.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.