From: "Paul E. McKenney" <paulmck@us.ibm.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Matt Helsley <matthltc@us.ibm.com>, Andrew Morton <akpm@osdl.org>,
dipankar@in.ibm.com, Ingo Molnar <mingo@elte.hu>,
tytso@us.ibm.com, Darren Hart <dvhltc@us.ibm.com>,
oleg@tv-sign.ru, Jes Sorensen <jes@sgi.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: SRCU-based notifier chains
Date: Tue, 11 Jul 2006 11:22:15 -0700 [thread overview]
Message-ID: <20060711182215.GF1288@us.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0607111357300.18796-100000@iolanthe.rowland.org>
On Tue, Jul 11, 2006 at 02:03:50PM -0400, Alan Stern wrote:
> On Tue, 11 Jul 2006, Paul E. McKenney wrote:
>
> > Looks sane to me. A couple of minor comments interspersed.
>
> Okay, I'll submit it with a proper writeup.
>
> > > +/*
> > > + * SRCU notifier chain routines. Registration and unregistration
> > > + * use a mutex, and call_chain is synchronized by SRCU (no locks).
> > > + */
> >
> > Hmmm... Probably my just failing to pay attention, but haven't noticed
> > the double-header-comment style before.
>
> As far as I know, I made it up. It seemed appropriate, since the first
> header applies to the entire group of three routines that follow whereas
> the second header is kerneldoc just for the next function.
Fair enough -- I missed the fact that the first header applies to
all three functions.
> > > /*
> > > - * Notifier chains are of three types:
> > > + * Notifier chains are of four types:
> >
> > Is it possible to subsume one of the other three types?
> >
> > Might not be, but have to ask...
>
> In principle we could replace blocking notifiers, but in practice we
> can't.
>
> We can't just substitute one for the other for two reasons: SRCU notifiers
> need special initialization which the blocking notifiers don't have, and
> SRCU notifiers have different time/space tradeoffs which might not be
> appropriate for all existing blocking notifiers.
Again, fair enough!
Thanx, Paul
next prev parent reply other threads:[~2006-07-11 18:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.44L0.0607061603320.5768-100000@iolanthe.rowland.org>
[not found] ` <1152226204.21787.2093.camel@stark>
2006-07-06 23:39 ` [PATCH 1/2] srcu-3: RCU variant permitting read-side blocking Paul E. McKenney
[not found] ` <Pine.LNX.4.44L0.0607071051430.17135-100000@iolanthe.rowland.org>
2006-07-07 16:33 ` Paul E. McKenney
[not found] ` <Pine.LNX.4.44L0.0607071345270.6793-100000@iolanthe.rowland.org>
2006-07-07 18:59 ` Paul E. McKenney
2006-07-07 19:59 ` Alan Stern
2006-07-07 21:11 ` Matt Helsley
2006-07-07 21:47 ` Paul E. McKenney
2006-07-10 19:11 ` SRCU-based notifier chains Alan Stern
2006-07-11 17:39 ` Paul E. McKenney
2006-07-11 18:03 ` Alan Stern
2006-07-11 18:22 ` Paul E. McKenney [this message]
2006-07-11 18:18 ` [PATCH] Add " Alan Stern
2006-07-11 18:30 ` Paul E. McKenney
2006-07-12 0:56 ` Chandra Seetharaman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060711182215.GF1288@us.ibm.com \
--to=paulmck@us.ibm.com \
--cc=akpm@osdl.org \
--cc=dipankar@in.ibm.com \
--cc=dvhltc@us.ibm.com \
--cc=jes@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthltc@us.ibm.com \
--cc=mingo@elte.hu \
--cc=oleg@tv-sign.ru \
--cc=stern@rowland.harvard.edu \
--cc=tytso@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.