From: kupcevic@sourceware.org <kupcevic@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] conga/ricci Changelog TODO modules/storage/BD. ...
Date: 12 Jul 2006 19:47:52 -0000 [thread overview]
Message-ID: <20060712194752.30779.qmail@sourceware.org> (raw)
CVSROOT: /cvs/cluster
Module name: conga
Changes by: kupcevic at sourceware.org 2006-07-12 19:47:51
Modified files:
ricci : Changelog TODO
ricci/modules/storage: BD.h LV.cpp LV.h
Log message:
storage module: remove snapshot_usage from state_ind
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/ricci/Changelog.diff?cvsroot=cluster&r1=1.1&r2=1.2
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/ricci/TODO.diff?cvsroot=cluster&r1=1.1&r2=1.2
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/ricci/modules/storage/BD.h.diff?cvsroot=cluster&r1=1.2&r2=1.3
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/ricci/modules/storage/LV.cpp.diff?cvsroot=cluster&r1=1.3&r2=1.4
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/ricci/modules/storage/LV.h.diff?cvsroot=cluster&r1=1.2&r2=1.3
--- conga/ricci/Changelog 2006/07/05 21:44:07 1.1
+++ conga/ricci/Changelog 2006/07/12 19:47:50 1.2
@@ -0,0 +1,6 @@
+
+2006-07-12 Stanko Kupcevic <kupcevic@redhat.com>
+ * ricci: unauthenticate() should always succeed
+ * storage module: remove snapshot_usage from state_ind (snapshot usage shouldn't affect state_ind)
+
+
--- conga/ricci/TODO 2006/07/05 21:44:07 1.1
+++ conga/ricci/TODO 2006/07/12 19:47:50 1.2
@@ -5,7 +5,6 @@
Ricci:
- - unauthenticate() should always succeed
- make ricci-auth secure (check Ryan's patch, and ask for review)
@@ -24,7 +23,6 @@
- Storage
- add scan_scsi_bus()
- remove mirror copy progress from state_ind
- - remove snapshot_usage from state_ind
- try to first umount all targets on mapper removal, remount on failure
- swap label on partitions
- hidden content to partition_template
--- conga/ricci/modules/storage/BD.h 2006/03/10 17:50:11 1.2
+++ conga/ricci/modules/storage/BD.h 2006/07/12 19:47:50 1.3
@@ -64,7 +64,7 @@
virtual ~BD();
std::string path() const;
- std::string state_ind() const;
+ virtual std::string state_ind() const;
virtual long long size() const;
std::string mapper_id() const;
std::string mapper_type() const;
--- conga/ricci/modules/storage/LV.cpp 2006/06/28 20:09:08 1.3
+++ conga/ricci/modules/storage/LV.cpp 2006/07/12 19:47:50 1.4
@@ -163,6 +163,21 @@
+string
+LV::state_ind() const
+{
+ Props tmp_props(_props);
+
+ // remove "snapshot_usage_percent" as its change shouldn't affect state_ind
+ tmp_props.set(Variable("snapshot_usage_percent", (long long) 0));
+
+ XMLObject t;
+ t.add_child(tmp_props.xml());
+ t.add_child(content->xml());
+
+ return utils::hash_str(generateXML(t) + path() + _mapper_id);
+}
+
counting_auto_ptr<BD>
LV::apply(const BDParsed& bd_parsed)
{
--- conga/ricci/modules/storage/LV.h 2006/03/10 17:50:11 1.2
+++ conga/ricci/modules/storage/LV.h 2006/07/12 19:47:50 1.3
@@ -36,6 +36,8 @@
LV(const std::string& path);
virtual ~LV();
+ virtual std::string state_ind() const;
+
virtual void remove();
virtual counting_auto_ptr<BD> apply(const BDParsed& bd); // return new bd
reply other threads:[~2006-07-12 19:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060712194752.30779.qmail@sourceware.org \
--to=kupcevic@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.