From: Muli Ben-Yehuda <muli@il.ibm.com>
To: Jeremy Kerr <jk@ozlabs.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: simplify dma_ops bug conditions
Date: Thu, 13 Jul 2006 09:39:47 +0300 [thread overview]
Message-ID: <20060713063947.GD5096@rhun.ibm.com> (raw)
In-Reply-To: <20060713063252.1D35867B58@ozlabs.org>
On Thu, Jul 13, 2006 at 04:32:52PM +1000, Jeremy Kerr wrote:
> Use BUG_ON rather than BUG to simplify the dma_ops handing,
> and remove the now-unnecessary return cases.
>
> Booted on pseries.
Is the BUG_ON() necessary? the next line just goes and deref's it,
which should lead to a shiny NULL pointer deref.
Cheers,
Muli
next prev parent reply other threads:[~2006-07-13 6:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-13 6:32 [PATCH] powerpc: simplify dma_ops bug conditions Jeremy Kerr
2006-07-13 6:39 ` Muli Ben-Yehuda [this message]
2006-07-17 3:55 ` Jeremy Kerr
[not found] ` <200607171355.10077.jk@ozlabs.org>
[not found] ` <20060717062825.GA18291@rhun.ibm.com>
2006-07-17 6:31 ` Muli Ben-Yehuda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060713063947.GD5096@rhun.ibm.com \
--to=muli@il.ibm.com \
--cc=jk@ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.