From: Andi Kleen <ak@suse.de>
To: Michal Schmidt <xschmi00@stud.feec.vutbr.cz>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: [patch] IDE: Touch NMI watchdog during resume from STR
Date: Thu, 13 Jul 2006 19:36:34 +0200 [thread overview]
Message-ID: <200607131936.34832.ak@suse.de> (raw)
In-Reply-To: <44B683EB.20709@stud.feec.vutbr.cz>
On Thursday 13 July 2006 19:33, Michal Schmidt wrote:
> Andi Kleen wrote:
> > Michal Schmidt <xschmi00@stud.feec.vutbr.cz> writes:
> >> if (stat == 0xff)
> >> return -ENODEV;
> >> touch_softlockup_watchdog();
> >> + touch_nmi_watchdog();
> > You can remove the touch_softlock_watchdog then. It's implied in
> > touch_nmi_watchdog
>
> I don't think that's always true. There are architectures where
> touch_nmi_watchdog is a NOP. This is in include/linux/nmi.h:
>
> #ifdef ARCH_HAS_NMI_WATCHDOG
> extern void touch_nmi_watchdog(void);
> #else
> # define touch_nmi_watchdog() do { } while(0)
> #endif
That's broken code then. It should be defined to touch_softlock_watchdog
for the !ARCH_HAS_NMI_WATCHDOG then.
-Andi
next prev parent reply other threads:[~2006-07-13 17:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-13 10:14 [patch] IDE: Touch NMI watchdog during resume from STR Michal Schmidt
2006-07-13 13:28 ` Andi Kleen
2006-07-13 17:33 ` Michal Schmidt
2006-07-13 17:36 ` Andi Kleen [this message]
2006-07-23 22:06 ` [PATCH] Make touch_nmi_watchdog imply touch_softlockup_watchdog on all archs Michal Schmidt
2006-07-24 7:15 ` Ingo Molnar
2006-07-14 19:06 ` [patch] IDE: Touch NMI watchdog during resume from STR Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200607131936.34832.ak@suse.de \
--to=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=xschmi00@stud.feec.vutbr.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.