From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Michael Gilbert <michael.s.gilbert@gmail.com>
Subject: Re: [Qemu-devel] fix for qemu-* looping forever on symlinks (patch attached)
Date: Fri, 14 Jul 2006 04:30:00 +0100 [thread overview]
Message-ID: <200607140430.01678.paul@codesourcery.com> (raw)
In-Reply-To: <8e2a98be0607131931i614eae05n8b95715e13f46efd@mail.gmail.com>
On Friday 14 July 2006 03:31, Michael Gilbert wrote:
> please review the attached patch (to linux-user/path.c), which i
> believe fixes the problem of qemu looping forever on symlinks when
> using -L. it is undesirable (i believe) for the -L option to search
> all subdirectories. this is in reference to debian bug #297572
> (bugs.debian.org/297572).
Have you tried running dynamically linked executables with your patch?
The whole point of the -L option is so that it picks up target shared
libraries, eg. in lib and usr/lib. By my reading your patch makes the -L
option do absolutely nothing, which can't be right.
The proper fix is to do the lookups when a file is accesses (possibly with
caching) not pre-scan the whole tree.
Paul
next prev parent reply other threads:[~2006-07-14 3:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-14 2:31 [Qemu-devel] fix for qemu-* looping forever on symlinks (patch attached) Michael Gilbert
2006-07-14 3:30 ` Paul Brook [this message]
2006-07-15 22:34 ` Anderson Lizardo
2006-07-15 22:39 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200607140430.01678.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=michael.s.gilbert@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.