From: Christoph Hellwig <hch@lst.de>
To: Samuel Ortiz <samuel@sortiz.org>
Cc: Christoph Hellwig <hch@lst.de>,
David Miller <davem@davemloft.net>,
shemminger@osdl.org, netdev@vger.kernel.org,
support@pathscale.com, kkeil@suse.de, kai.germaschewski@gmx.de,
chas@cmf.nrl.navy.mil, paulus@samba.org
Subject: Re: [PATCH 2/2] correct dev_alloc_skb kerneldoc
Date: Fri, 14 Jul 2006 08:49:03 +0200 [thread overview]
Message-ID: <20060714064903.GA8355@lst.de> (raw)
In-Reply-To: <20060714072726.GB6458@sortiz.org>
On Fri, Jul 14, 2006 at 10:27:27AM +0300, Samuel Ortiz wrote:
> > The patchkit for this is at http://verein.lst.de/~hch/patches.skb.tgz, it
> > includes the first two cleanup patches I posted previously (Any plans
> > to put them in?), a patch to move __dev_alloc_skb out of line because
> > otherwise we'd need to include netdevice.h in skbuff.h which creates
> > lots of problems (and moving it out of lines shaves 10kb off a
> > allyesconfig), the dev_alloc_skb prototype changes and some experimental
> > patches to make dev_alloc_skb nodeaware.
> In those patches you change dev_alloc_skb prototype, but then the new netdev
> argument is not used by __dev_alloc_skb() to allocate the sk_buff on the
> correct node. Do you plan to introduce an alloc_skb_node() later or am I
> missing something ?
The nodeaware-skb_alloc patch later in the series introduces a node
argument to __alloc_skb. the nodeaware-netdev patch adds a node
argument to struct netdevice that dev_alloc_skb then passes to
__alloc_skb. All of these patches are in the tarball my previous mail
points to.
next prev parent reply other threads:[~2006-07-14 6:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-07 9:09 [PATCH 2/2] correct dev_alloc_skb kerneldoc Christoph Hellwig
2006-07-07 22:52 ` Stephen Hemminger
2006-07-07 23:55 ` David Miller
2006-07-08 3:11 ` Herbert Xu
2006-07-08 10:48 ` Christoph Hellwig
2006-07-08 20:37 ` David Miller
2006-07-13 20:36 ` Christoph Hellwig
2006-07-13 20:47 ` Randy.Dunlap
2006-07-13 20:47 ` David Miller
2006-07-14 15:24 ` chas williams - CONTRACTOR
2006-07-13 21:24 ` Stephen Hemminger
2006-07-13 21:29 ` Christoph Hellwig
2006-07-13 22:01 ` David Miller
2006-07-14 7:27 ` Samuel Ortiz
2006-07-14 6:49 ` Christoph Hellwig [this message]
2006-07-24 22:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060714064903.GA8355@lst.de \
--to=hch@lst.de \
--cc=chas@cmf.nrl.navy.mil \
--cc=davem@davemloft.net \
--cc=kai.germaschewski@gmx.de \
--cc=kkeil@suse.de \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=samuel@sortiz.org \
--cc=shemminger@osdl.org \
--cc=support@pathscale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.