From: Andi Kleen <ak@suse.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: torvalds@osdl.org, akpm@osdl.org, discuss@x86-64.org,
linux-kernel@vger.kernel.org,
Chuck Ebbert <76306.1226@compuserve.com>
Subject: Re: [PATCH for 2.6.18-rc2] [2/8] i386/x86-64: Don't randomize stack top when no randomization personality is set
Date: Sun, 16 Jul 2006 23:14:07 +0200 [thread overview]
Message-ID: <200607162314.07764.ak@suse.de> (raw)
In-Reply-To: <20060716204712.GA29161@elte.hu>
On Sunday 16 July 2006 22:47, Ingo Molnar wrote:
> * Andi Kleen <ak@suse.de> wrote:
> > unsigned long arch_align_stack(unsigned long sp)
> > {
> > - if (randomize_va_space)
> > + if (!(current->personality & ADDR_NO_RANDOMIZE) && randomize_va_space)
> > sp -= get_random_int() % 8192;
> > return sp & ~0xf;
>
> i'm not opposing this patch at all, but didnt the performance problems
> go away when the 0xf was changed to 0x7f?
Yes, but i sent the patch before that other patch was available.
I guess it's a separate issue anyways - this patch is just concerned about
disabling randomization consistently. Performance optimization can be done
in another one.
-Andi
next prev parent reply other threads:[~2006-07-16 21:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-16 12:22 [PATCH for 2.6.18-rc2] [2/8] i386/x86-64: Don't randomize stack top when no randomization personality is set Andi Kleen
2006-07-16 20:47 ` Ingo Molnar
2006-07-16 21:14 ` Andi Kleen [this message]
2006-07-16 21:11 ` Ingo Molnar
2006-07-16 21:27 ` Andi Kleen
2006-07-16 21:33 ` [discuss] Re: [PATCH for 2.6.18-rc2] [2/8] i386/x86-64: Don't randomize stack top when no randomization personality is set II Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200607162314.07764.ak@suse.de \
--to=ak@suse.de \
--cc=76306.1226@compuserve.com \
--cc=akpm@osdl.org \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.