From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: Panagiotis Issaris <takis@lumumba.uhasselt.be>,
linux-scsi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linux-eata@i-connect.net
Subject: Re: [PATCH 1/2] Conversions from kmalloc+memset to k(z|c)alloc
Date: Wed, 19 Jul 2006 08:23:39 +0200 [thread overview]
Message-ID: <200607190823.39571.eike-kernel@sf-tec.de> (raw)
In-Reply-To: <20060719013113.GF30823@lumumba.uhasselt.be>
Added linux-scsi to CC as it touches drivers/scsi/
> /* stuff a sense request in front of our current request */
> - pc = kmalloc (sizeof (idescsi_pc_t), GFP_ATOMIC);
> + pc = kzalloc (sizeof (idescsi_pc_t), GFP_ATOMIC);
Please remove the space before the arguments.
> rq = kmalloc (sizeof (struct request), GFP_ATOMIC);
This and the one before should be "rq = kzalloc(sizeof(*rq),...);" This way
you will always get the correct buffer size even if the type of rq changes.
Eike
prev parent reply other threads:[~2006-07-19 6:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-19 1:31 [PATCH 1/2] Conversions from kmalloc+memset to k(z|c)alloc Panagiotis Issaris
2006-07-19 6:23 ` Rolf Eike Beer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200607190823.39571.eike-kernel@sf-tec.de \
--to=eike-kernel@sf-tec.de \
--cc=linux-eata@i-connect.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=takis@lumumba.uhasselt.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.