From: Andrew Morton <akpm@osdl.org>
To: Auke Kok <auke-jan.h.kok@intel.com>
Cc: pavel@ucw.cz, auke-jan.h.kok@intel.com, cramerj@intel.com,
john.ronciak@intel.com, jesse.brandeburg@intel.com,
jeffrey.t.kirsher@intel.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: e1000: "fix" it on thinkpad x60 / eeprom checksum read fails
Date: Fri, 21 Jul 2006 06:41:05 -0700 [thread overview]
Message-ID: <20060721064105.aa960acd.akpm@osdl.org> (raw)
In-Reply-To: <44BFBE9F.7070600@intel.com>
On Thu, 20 Jul 2006 10:34:23 -0700
Auke Kok <auke-jan.h.kok@intel.com> wrote:
> > Okay, perhaps this should be inserted as a comment into the driver,
> > and printk should be fixed to point at this explanation?
> >
> > Can't we enable the driver with the bad checksum, then read the _real_
> > data?
>
> no.
>
> We're working on a solution where we make sure that the PHY is physically
> turned on properly before we read the EEPROM, which would be the proper fix.
> It's completely not acceptable to run when the EEPROM checksum fails - you
> might even be running with the wrong MAC address, or worse. Lets fix this the
> right way instead.
A printk which helps the user to understand all this saga would be very nice.
next prev parent reply other threads:[~2006-07-21 13:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-21 0:58 e1000: "fix" it on thinkpad x60 Pavel Machek
2006-07-20 16:21 ` e1000: "fix" it on thinkpad x60 / eeprom checksum read fails Auke Kok
2006-07-20 17:07 ` Pavel Machek
2006-07-20 17:34 ` Auke Kok
2006-07-21 13:41 ` Andrew Morton [this message]
2006-07-21 15:12 ` Theodore Tso
2006-07-21 15:22 ` Auke Kok
2006-07-22 0:21 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060721064105.aa960acd.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=auke-jan.h.kok@intel.com \
--cc=cramerj@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.