From: Phil Oester <kernel@linuxace.com>
To: Yasuyuki KOZAKAI <yasuyuki.kozakai@toshiba.co.jp>
Cc: netfilter-devel@lists.netfilter.org, kaber@trash.net
Subject: Re: [PATCH] proto_to_name duplication
Date: Mon, 24 Jul 2006 07:49:50 -0700 [thread overview]
Message-ID: <20060724144950.GA8973@linuxace.com> (raw)
In-Reply-To: <200607240538.k6O5cYwP024759@toshiba.co.jp>
On Mon, Jul 24, 2006 at 02:38:32PM +0900, Yasuyuki KOZAKAI wrote:
> This allows iptables to send the invalid entry to kernel when
> people do 'iptables -p icmp -m multiport --sports 10000 ...',
> for example. Of cause kernel can reject this, but iptables cannot
> output useful error message after that.
>
> check_proto() should not allow protocols other than tcp, udp, sctp and
> dccp. That's why libip{,6}t_multiport have the other version of
> proto_to_name().
>
> Please revert this or add check for protocol number.
Good catch. Probably should just revert this one for simplicity.
Phil
next prev parent reply other threads:[~2006-07-24 14:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-21 22:56 [PATCH] proto_to_name duplication Phil Oester
2006-07-22 13:47 ` Patrick McHardy
2006-07-22 16:39 ` Phil Oester
2006-07-24 5:38 ` Yasuyuki KOZAKAI
2006-07-24 14:49 ` Phil Oester [this message]
2006-07-25 1:21 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060724144950.GA8973@linuxace.com \
--to=kernel@linuxace.com \
--cc=kaber@trash.net \
--cc=netfilter-devel@lists.netfilter.org \
--cc=yasuyuki.kozakai@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.