From: Stephen Hemminger <shemminger@osdl.org>
To: Daniel Drake <dsd@gentoo.org>
Cc: Tom Walter Dillig <tdillig@stanford.edu>,
linux-kernel@vger.kernel.org, w@1wt.eul,
kernel_org@digitalpeer.com, security@kernel.org,
Netdev list <netdev@vger.kernel.org>
Subject: Re: softmac possible null deref [was: Complete report of Null dereference errors in kernel 2.6.17.1]
Date: Mon, 24 Jul 2006 17:12:13 -0700 [thread overview]
Message-ID: <20060724171213.62810d2b@localhost.localdomain> (raw)
In-Reply-To: <44C55F36.5000701@gentoo.org>
On Tue, 25 Jul 2006 01:00:54 +0100
Daniel Drake <dsd@gentoo.org> wrote:
> Tom Walter Dillig wrote:
> > [109]
> > 452 net/ieee80211/softmac/ieee80211softmac_io.c
> > Possible null dereference of variable "*pkt" in function call
> > (include/asm/string.h:__constant_c_and_count_memset) checked at
> > (453:net/ieee80211/softmac/ieee80211softmac_io.c)
>
> Either I'm misunderstanding, or this is bogus.
>
> when *pkt is allocated by the various child functions (e.g.
> ieee80211softmac_disassoc_deauth), it is always checked for NULL.
>
> Finally, line 453 does another NULL check.
>
> What is the report trying to say?
That the check in 453 should be removed because is unneeded.
People who obsess about code coverage care that there are unneded
checks. I don't think it matters.
next prev parent reply other threads:[~2006-07-25 0:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-24 23:10 Complete report of Null dereference errors in kernel 2.6.17.1 Tom Walter Dillig
2006-07-25 0:00 ` softmac possible null deref [was: Complete report of Null dereference errors in kernel 2.6.17.1] Daniel Drake
2006-07-25 0:12 ` Stephen Hemminger [this message]
2006-07-25 0:01 ` Daniel Drake
2006-07-25 0:00 ` Thomas Dillig
2006-07-25 6:20 ` Johannes Weiner
2006-07-26 13:11 ` Daniel Drake
2006-07-29 17:46 ` Complete report of Null dereference errors in kernel 2.6.17.1 Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060724171213.62810d2b@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=dsd@gentoo.org \
--cc=kernel_org@digitalpeer.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=security@kernel.org \
--cc=tdillig@stanford.edu \
--cc=w@1wt.eul \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.