From: Stephen Hemminger <shemminger@osdl.org>
To: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH] ip multicast route bug fix
Date: Tue, 25 Jul 2006 14:24:43 -0700 [thread overview]
Message-ID: <20060725142443.42969ea6@localhost.localdomain> (raw)
In-Reply-To: <20060725211725.GA24366@ms2.inr.ac.ru>
On Wed, 26 Jul 2006 01:17:25 +0400
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru> wrote:
> Hello!
>
> > Wouldn't it be better to have a consistent interface (skb always freed),
> > and clone the skb if needed for deferred processing?
>
> I think you mean this.
>
> Note, it is real skb_clone(), not alloc_skb(). Equeued skb contains
> the whole half-prepared netlink message plus room for the rest.
> It could be also skb_copy(), if we want to be puristic about mangling
> cloned data, but original copy is really not going to be used.
>
> Alexey
>
That is what I was thinking of. Doesn't matter copy or clone, I prefer
clone.
next prev parent reply other threads:[~2006-07-25 21:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-19 21:57 [PATCH] ip multicast route bug fix Stephen Hemminger
2006-07-25 5:29 ` James Morris
2006-07-25 6:03 ` Martin Josefsson
2006-07-25 8:03 ` Herbert Xu
2006-07-25 15:42 ` [PATCH] ip multicast route bug fix (rev2) Stephen Hemminger
2006-07-25 16:20 ` [PATCH] ip multicast route bug fix Alexey Kuznetsov
2006-07-25 15:55 ` Stephen Hemminger
2006-07-25 16:48 ` Alexey Kuznetsov
2006-07-25 18:31 ` Alexey Kuznetsov
2006-07-25 21:17 ` Alexey Kuznetsov
2006-07-25 21:24 ` Stephen Hemminger [this message]
2006-07-25 23:45 ` David Miller
2006-07-26 2:26 ` Herbert Xu
2006-07-26 13:27 ` Alexey Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060725142443.42969ea6@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=davem@davemloft.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.