From: Ingo Molnar <mingo@elte.hu>
To: Dave Jones <davej@redhat.com>,
linux-kernel@vger.kernel.org, 76306.1226@compuserve.com
Subject: Re: + spinlock_debug-dont-recompute-jiffies_per_loop.patch added to -mm tree
Date: Tue, 25 Jul 2006 22:43:06 +0200 [thread overview]
Message-ID: <20060725204306.GA22547@elte.hu> (raw)
In-Reply-To: <20060725204228.GE13829@redhat.com>
* Dave Jones <davej@redhat.com> wrote:
> > iteration limit, gets recomputed every time. Caching it explicitly
> > prevents that.
>
> What is the purpose of those __delays being there at all ? Seems odd
> to be waiting that long when the spinlock could become available a lot
> sooner. (These also make spinlock debug really painful on boxes with
> huge numbers of CPUs).
the debug code has to figure out when to trigger a deadlock warning
message. If we are looping in a deadlock with irqs disabled on all CPUs,
there's nothing that advances jiffies. The TSC is not reliable. The
thing that remains is to use __delay(1). We could calibrate the loop
separately perhaps?
Ingo
next prev parent reply other threads:[~2006-07-25 20:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200607251910.k6PJASfo006168@shell0.pdx.osdl.net>
2006-07-25 20:42 ` + spinlock_debug-dont-recompute-jiffies_per_loop.patch added to -mm tree Dave Jones
2006-07-25 20:43 ` Ingo Molnar [this message]
2006-07-27 5:53 Chuck Ebbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060725204306.GA22547@elte.hu \
--to=mingo@elte.hu \
--cc=76306.1226@compuserve.com \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.