From: Pavel Machek <pavel@suse.cz>
To: David Brownell <david-b@pacbell.net>
Cc: linux-pm@lists.osdl.org, Jason Lunz <lunz@falooley.org>,
linux-ide@vger.kernel.org, Vojtech Pavlik <vojtech@suse.cz>
Subject: Re: [linux-pm] [patch, rft] amd74xx: implement suspend-to-ram
Date: Wed, 26 Jul 2006 11:02:04 +0200 [thread overview]
Message-ID: <20060726090204.GC1905@elf.ucw.cz> (raw)
In-Reply-To: <200607251727.12678.david-b@pacbell.net>
Hi!
> > and please don't do this. Suspend-to-disk will call
> > amd74xx_resume when it needs to talk to the disk.
>
> I don't understand the rest of this comment. That code looks
> correct (other than calling the goofy/broken pci_choose_state thing);
> PM_EVENT_FREEZE and PM_EVENT_PRETHAW should not disable the device.
Well, I'd prefer PM_EVENT_FREEZE and PM_EVENT_SUSPEND to be the same
code (i.e. remove the if() and just do
> > > + pci_disable_device(dev);
> > > + pci_set_power_state(dev, pci_choose_state(dev, state));
unconditionaly). It should also work, and not really be slower.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2006-07-26 9:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-15 21:05 amd74xx crashes when resuming from STR Jason Lunz
2006-07-18 4:34 ` [linux-pm] " Pavel Machek
2006-07-18 4:35 ` Pavel Machek
[not found] ` <19700101003716.GA3558@ucw.cz>
2006-07-18 13:39 ` [linux-pm] " Vojtech Pavlik
2006-07-24 0:53 ` [patch, rft] amd74xx: implement suspend-to-ram Jason Lunz
2006-07-25 23:09 ` Pavel Machek
2006-07-26 0:27 ` [linux-pm] " David Brownell
2006-07-26 2:45 ` [patch v2] amd74xx: fix hang on resume from ram Jason Lunz
2006-07-26 3:14 ` [patch v3] " Jason Lunz
2006-07-27 20:35 ` David Brownell
2006-07-26 9:02 ` Pavel Machek [this message]
2006-07-27 0:29 ` [linux-pm] [patch, rft] amd74xx: implement suspend-to-ram David Brownell
2006-07-27 20:49 ` Pavel Machek
2006-07-27 22:43 ` Jason Lunz
2006-07-27 22:51 ` Pavel Machek
2006-07-28 9:15 ` Rafael J. Wysocki
2006-07-28 13:23 ` Vojtech Pavlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060726090204.GC1905@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=david-b@pacbell.net \
--cc=linux-ide@vger.kernel.org \
--cc=linux-pm@lists.osdl.org \
--cc=lunz@falooley.org \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.