Re: [PATCH] Mini-OS to use evtchn_port_t for ports and other improvements

[Steven Smith <sos22-xen@srcf.ucam.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1150 bytes --]

> > Why maybe_bind?  Do you ever expect to need to allocate an unbound
> > event channel before you know what handler to use for it?
> I wanted to capture the usual pattern of immediately binding a port
> after it's allocated, without forcing programmers to follow that
> pattern.
That's not a bad idea, but I'd rather leave this until we have an
example of some actual code which needs it.

> > > +    evtchn_port_t port = op.u.bind_interdomain.local_port;
> > > +    clear_evtchn(port);	      /* Without, handler gets invoked now! */
> > Invoking the handler as soon as you bind the interdomain channel is
> > a mostly-deliberate part of the interface.  If the other end makes
> > notifications before you get around to binding they can get lost,
> > and forcing the channel to fire as soon as you bind to it avoids
> > some potential lost wakeups.
> It's easy to simulate the case of a handler call on binding with
> clear_evtchn included, but a pain to handle the case in which one
> wants the handler to be invoked only when a notification arrives,
> when it is omitted.
I think you have a point here.  Consider my objection withdrawn.

Steven.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel