From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] [PATCH] atxp1: signed/unsigned char bug
Date: Thu, 27 Jul 2006 18:20:53 +0000 [thread overview]
Message-ID: <20060727202053.2e9e18e3.khali@linux-fr.org> (raw)
In-Reply-To: <20060724083118.GB6815@martell.zuzino.mipt.ru>
Hi Alexey,
> vid_to_reg() can return -1 and char can be unsigned.
What does it take for char be unsigned? Never seen that.
> Signed-off-by: Alexey Dobriyan <adobriyan at gmail.com>
> ---
>
> drivers/hwmon/atxp1.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> --- a/drivers/hwmon/atxp1.c
> +++ b/drivers/hwmon/atxp1.c
> @@ -116,8 +116,7 @@ static ssize_t atxp1_storevcore(struct d
> {
> struct atxp1_data *data;
> struct i2c_client *client;
> - char vid;
> - char cvid;
> + int vid, cvid;
> unsigned int vcore;
>
> client = to_i2c_client(dev);
Whatever, this looks better with ints, I agree. I'll take that patch,
unless Sebastian objects.
--
Jean Delvare
next prev parent reply other threads:[~2006-07-27 18:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-24 8:31 [lm-sensors] [PATCH] atxp1: signed/unsigned char bug Alexey Dobriyan
2006-07-27 18:20 ` Jean Delvare [this message]
2006-07-27 18:30 ` Alexey Dobriyan
2006-07-27 19:15 ` Sebastian Witt
2006-07-27 20:28 ` Jean Delvare
2006-07-27 20:36 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060727202053.2e9e18e3.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.