From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] [PATCH] hwmon: re-order CONFIG_HWMON_DEBUG_CHIP
Date: Thu, 27 Jul 2006 19:46:19 +0000 [thread overview]
Message-ID: <20060727214619.10764837.khali@linux-fr.org> (raw)
In-Reply-To: <20060720002807.GD8584@krypton>
Hi Arthur,
Care to change your "From:" to the standard notation?
> Move CONFIG_HWMON_DEBUG_CHIP higher up so it's more accessible.
>
> Signed-off-by: Arthur Othieno <apgo at patchbomb.org>
> ---
> drivers/hwmon/Kconfig | 20 ++++++++++----------
> 1 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 0e31a0c..5284491 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -23,6 +23,16 @@ config HWMON
> This support can also be built as a module. If so, the module
> will be called hwmon.
>
> +config HWMON_DEBUG_CHIP
> + bool "Hardware Monitoring Chip debugging messages"
> + depends on HWMON
> + default n
> + help
> + Say Y here if you want the I2C chip drivers to produce a bunch of
> + debug messages to the system log. Select this if you are having
> + a problem with I2C support and want to see more of what is going
> + on.
> +
> config HWMON_VID
> tristate
> default n
> @@ -507,14 +517,4 @@ config SENSORS_HDAPS
> Say Y here if you have an applicable laptop and want to experience
> the awesome power of hdaps.
>
> -config HWMON_DEBUG_CHIP
> - bool "Hardware Monitoring Chip debugging messages"
> - depends on HWMON
> - default n
> - help
> - Say Y here if you want the I2C chip drivers to produce a bunch of
> - debug messages to the system log. Select this if you are having
> - a problem with I2C support and want to see more of what is going
> - on.
> -
> endmenu
I'm not convinced sorry. It is common to have the debug options after
the affected drivers, be they individual or not. And the bottom of the
screen isn't that far ;)
What would be much more interesting would be to update the text and
replace occurences of "I2C" by "hardware monitoring"! One mode stupid
copy-n-paste typo. Care to send a patch?
Thanks,
--
Jean Delvare
prev parent reply other threads:[~2006-07-27 19:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-20 0:28 [lm-sensors] [PATCH] hwmon: re-order CONFIG_HWMON_DEBUG_CHIP Arthur Othieno
2006-07-27 19:46 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060727214619.10764837.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.