From: Christoph Hellwig <hch@infradead.org>
To: NeilBrown <neilb@suse.de>
Cc: Andrew Morton <akpm@osdl.org>,
nfs@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 000 of 2] knfsd: Don't allow bad file handles to cause extX to go readonly
Date: Fri, 28 Jul 2006 14:33:21 +0100 [thread overview]
Message-ID: <20060728133321.GA439@infradead.org> (raw)
In-Reply-To: <20060728102713.15132.patches@notabene>
On Fri, Jul 28, 2006 at 10:31:20AM +1000, NeilBrown wrote:
> Currently, and file handle with a bad inode number in it can cause
> ext2 to go to readonly (as it looks like a corrupted filesystem)
> and could allow remote access to ext3 special files like the journal.
>
> These patches give ext2/3 their own get_dentry method which checks the
> inode number early before other bits of the code can be freaked out by
> it.
>
> These are revised versions of earlier patches. Rather than exporting
> export_iget, we open code it and simplify it slightly. This avoids
> and extra module dependancy.
This looks much better, agreed. Long-term we should switch ext2/ext2
to use iget_locked so we can propagate errors in finding the inode much
better.
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: NeilBrown <neilb@suse.de>
Cc: Andrew Morton <akpm@osdl.org>,
nfs@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [NFS] [PATCH 000 of 2] knfsd: Don't allow bad file handles to cause extX to go readonly
Date: Fri, 28 Jul 2006 14:33:21 +0100 [thread overview]
Message-ID: <20060728133321.GA439@infradead.org> (raw)
In-Reply-To: <20060728102713.15132.patches@notabene>
On Fri, Jul 28, 2006 at 10:31:20AM +1000, NeilBrown wrote:
> Currently, and file handle with a bad inode number in it can cause
> ext2 to go to readonly (as it looks like a corrupted filesystem)
> and could allow remote access to ext3 special files like the journal.
>
> These patches give ext2/3 their own get_dentry method which checks the
> inode number early before other bits of the code can be freaked out by
> it.
>
> These are revised versions of earlier patches. Rather than exporting
> export_iget, we open code it and simplify it slightly. This avoids
> and extra module dependancy.
This looks much better, agreed. Long-term we should switch ext2/ext2
to use iget_locked so we can propagate errors in finding the inode much
better.
next prev parent reply other threads:[~2006-07-28 13:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-28 0:31 [PATCH 000 of 2] knfsd: Don't allow bad file handles to cause extX to go readonly NeilBrown
2006-07-28 0:31 ` NeilBrown
2006-07-28 0:31 ` [PATCH 001 of 2] knfsd: Have ext2 reject file handles with bad inode numbers early NeilBrown
2006-07-28 0:31 ` NeilBrown
2006-07-28 0:31 ` [PATCH 002 of 2] knfsd: Make ext3 reject filehandles referring to invalid inode numbers NeilBrown
2006-07-28 0:31 ` NeilBrown
2006-07-28 13:33 ` Christoph Hellwig [this message]
2006-07-28 13:33 ` [NFS] [PATCH 000 of 2] knfsd: Don't allow bad file handles to cause extX to go readonly Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060728133321.GA439@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=nfs@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.