From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] [RFC PATCH] lib/access.c optimization
Date: Fri, 28 Jul 2006 13:29:09 +0000 [thread overview]
Message-ID: <20060728152909.6ac16403.khali@linux-fr.org> (raw)
In-Reply-To: <20060725041358.GB12109@jupiter.solarsys.private>
Hi Mark,
> Before anyone spends too much time on that patch... why are there so many
> 'strcasecmp' calls in libsensors? Did you know that you can specify 'in0'
> or 'IN0' in the config file and both have the same effect? I never even
> realized it until yesterday night. This case insensitivity is *nowhere*
> mentioned in the man pages.
I didn't know either.
> Can we get rid of that? If so, I'm gonna shave a lot more than 8% by
> using a hash for all the string/name to chip/feature/ignore lookups.
Yeah, let's get rid of it, I really don't see the point.
How are you going to implement your hash? I'm curious?
> BTW: valgrind 3.2.0 (w/ callgrind) plus kcachegrind rocks.
Don't know about callgrind and kcachegrind, but yeah, valgrind
definitely rocks.
--
Jean Delvare
next prev parent reply other threads:[~2006-07-28 13:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-25 4:13 [lm-sensors] [RFC PATCH] lib/access.c optimization Mark M. Hoffman
2006-07-27 1:31 ` Mark M. Hoffman
2006-07-28 13:29 ` Jean Delvare [this message]
2006-07-28 13:31 ` Jean Delvare
2006-07-29 1:55 ` Mark M. Hoffman
2006-07-29 2:09 ` Mark M. Hoffman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060728152909.6ac16403.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.