From: "John W. Linville" <linville@tuxdriver.com>
To: Greg KH <greg@kroah.com>
Cc: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
"Kok, Auke-jan H" <auke-jan.h.kok@intel.com>,
stable@kernel.org, NetDev <netdev@vger.kernel.org>,
"Ronciak, John" <john.ronciak@intel.com>,
"Kok, Auke" <auke@foo-projects.org>
Subject: Re: [stable] [PATCH] e1000: add forgotten PCI ID for supported device
Date: Fri, 28 Jul 2006 23:19:05 -0400 [thread overview]
Message-ID: <20060729031859.GA23779@tuxdriver.com> (raw)
In-Reply-To: <20060729002440.GA3284@kroah.com>
On Fri, Jul 28, 2006 at 05:24:40PM -0700, Greg KH wrote:
> On Fri, Jul 28, 2006 at 05:04:49PM -0700, Brandeburg, Jesse wrote:
> > The kernel driver advertises through our probe table and in our readme
> > that we support this device (code is in e1000_main.c) but we don't load on
> > it correctly due to an error when we submitted the patches (e1000_hw.c/h).
> >
> > Patch is very simple and low risk, but it is your call.
>
> Sorry, but for now, no. Users should be able to use the sysfs bind and
> new_id interface to add new device support for your driver, if it's
> written properly :)
In this case it isn't an addition to the PCI ID table, but an actual
added check in the code. You could make the argument that it is a
bug since the PCI ID table says the device is supported, but it won't
work w/o this additional check.
Of course, the "if it's written properly" comment is still valid... :-)
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2006-07-29 3:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-28 22:06 [PATCH] e1000: add forgotten PCI ID for supported device Auke Kok
2006-07-28 23:18 ` [stable] " Greg KH
2006-07-29 0:04 ` Brandeburg, Jesse
2006-07-29 0:24 ` Greg KH
2006-07-29 3:19 ` John W. Linville [this message]
2006-08-03 7:17 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060729031859.GA23779@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=auke-jan.h.kok@intel.com \
--cc=auke@foo-projects.org \
--cc=greg@kroah.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.