From: Andi Kleen <ak@suse.de>
To: discuss@x86-64.org, kmannth@us.ibm.com
Cc: lkml <linux-kernel@vger.kernel.org>,
lhms-devel <lhms-devel@lists.sourceforge.net>,
andrew <akpm@osdl.org>, kame <kamezawa.hiroyu@jp.fujitsu.com>,
dave hansen <haveblue@us.ibm.com>, konrad <darnok@us.ibm.com>
Subject: Re: [discuss] [Patch] 4/5 in support of hot-add memory x86_64 fix kernel mapping code
Date: Sat, 29 Jul 2006 18:32:09 +0200 [thread overview]
Message-ID: <200607291832.09995.ak@suse.de> (raw)
In-Reply-To: <1154141570.5874.148.camel@keithlap>
On Saturday 29 July 2006 04:52, keith mannthey wrote:
> Hello All,
>
> phys_pud_init is broken when using it at runtime with some offsets.
> It currently only maps one pud entry worth of pages while trampling any
> mappings that may have existed on the pmd_page :(
To print x86-64 ptes you need a %016lx (or just %lx)
it would be cleaner to recompute pmd inside the loop based on i
and use a standard for()
It is unclear why you hardcode 0 as address in phys_pmd_update
when a real address is passed in?
-Andi
next prev parent reply other threads:[~2006-07-29 16:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-29 2:52 [Patch] 4/5 in support of hot-add memory x86_64 fix kernel mapping code keith mannthey
2006-07-29 16:32 ` Andi Kleen [this message]
2006-07-29 20:11 ` [discuss] " keith mannthey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200607291832.09995.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=darnok@us.ibm.com \
--cc=discuss@x86-64.org \
--cc=haveblue@us.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kmannth@us.ibm.com \
--cc=lhms-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.