From: Pavel Machek <pavel@ucw.cz>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/6] Begin abstraction of sensitive instructions: asm files
Date: Sun, 30 Jul 2006 12:56:57 +0200 [thread overview]
Message-ID: <20060730105657.GA5830@elf.ucw.cz> (raw)
In-Reply-To: <20060730105228.GA5810@elf.ucw.cz>
Hi!
> > Abstract sensitive instructions in assembler code, replacing them with
> > macros (which currently are #defined to the native versions). We use
> > long names: assembler is case-insensitive, so if something goes wrong
> > and macros do not expand, it would assemble anyway.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > @@ -76,8 +76,15 @@
> > NT_MASK = 0x00004000
> > VM_MASK = 0x00020000
> >
> > +/* These are replaces for paravirtualization */
> > +#define DISABLE_INTERRUPTS cli
> > +#define ENABLE_INTERRUPTS sti
> > +#define ENABLE_INTERRUPTS_SYSEXIT sti; sysexit
> > +#define INTERRUPT_RETURN iret
>
> Could we use some less verbose names, like possibly CLI, STI,
> STI_SYSEXIT, IRET ?
Apparently I can't read, it was explained in changelog. Could we still
use something shorter, like perhaps _CLI / _STI / _IRET ?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2006-07-30 10:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-22 0:14 [PATCH 5/6] Begin abstraction of sensitive instructions: asm files Rusty Russell
2006-07-30 10:52 ` Pavel Machek
2006-07-30 10:56 ` Pavel Machek [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-07-22 3:23 Chuck Ebbert
2006-07-22 13:34 ` Rusty Russell
2006-07-24 17:36 ` Andi Kleen
2006-07-24 20:54 ` Jeremy Fitzhardinge
2006-07-25 23:52 ` Peter Chubb
2006-07-26 3:25 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060730105657.GA5830@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.