Re: Building external modules against objdirs

[Andi Kleen <ak@suse.de>]

On Sunday 30 July 2006 20:31, Sam Ravnborg wrote:
> On Sun, Jul 30, 2006 at 07:49:41PM +0200, Andi Kleen wrote:
> > 
> > > Can you check that you really did a 'make prepare' in the relevant
> > > output directory. Previously only the make *config step was needed.
> > 
> > The output directory is a full build (configuration + make without any targets).
> > Is that not enough anymore? 
> > 
> > Anyways after a make prepare it seems to work - thanks - but I think that
> > should be really done as part of the standard build like it was in 2.6.17.
> 'make prepare' is and has always been part of the standard build.
> So I really do not see what is going on.

To reproduce (on x86-64 at least)

mkdir obj
cd obj
make -C ../linux-2.6.18-... O=$(pwd) defconfig
make 



> Can you please check that followign files exists in your output
> directory:
> .config
> include/config/auto.conf.cmd
> include/config/auto.conf
> 
> the latter should be the latest of the three.

-rw-r--r--  1 andi users 28481 2006-07-29 19:01 .config
-rw-r--r--  1 andi users  7739 2006-07-29 19:07 include/config/auto.conf
-rw-r--r--  1 andi users  6867 2006-07-29 19:07 include/config/auto.conf.cmd

 
> Also try applying following patch to reveal why we trigger this rule:
> 
> diff --git a/Makefile b/Makefile
> index 1dd58d3..4c30ed5 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -453,6 +453,7 @@ include/config/auto.conf: $(KCONFIG_CONF
>  ifeq ($(KBUILD_EXTMOD),)
>  	$(Q)$(MAKE) -f $(srctree)/Makefile silentoldconfig
>  else
> +	@echo triggered by - $? -
>  	$(error kernel configuration not valid - run 'make prepare' in $(srctree) to update it)
>  endif


The echo didn't output for some reason, but adding it to the error gives

/home/lsrc/quilt/linux/Makefile:456: *** triggered by /home/lsrc/quilt/linux/drivers/net/wireless/Kconfig /home/lsrc/quilt/linux/drivers/message/fusion/Kconfig /home/lsrc/quilt/linux/net/ieee80211/Kconfig /home/lsrc/quilt/linux/net/netfilter/Kconfig kernel configuration not valid - run 'make prepare' in /home/lsrc/quilt/linux to update it.  Stop.
 
-Andi