From: Domen Puncer <domen@coderock.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] drivers/block/acsi.c: Add KERN_* to printk
Date: Mon, 31 Jul 2006 05:38:16 +0000 [thread overview]
Message-ID: <20060731053816.GE4969@nd47.coderock.org> (raw)
In-Reply-To: <20060731002238.GA10973@chello.nl>
On 31/07/06 02:22 +0200, Richard wrote:
...
> #ifdef DEBUG
> - printk("ACSI: skipping 0xff status byte\n" );
> + printk( KERN_DEBUG "ACSI: skipping 0xff status byte\n" );
> #endif
This looks like a perfect example of where pr_debug can be used.
> #ifdef DEBUG_DETECT
> - printk("target %d lun %d: timeout\n", aip->target, aip->lun);
> + printk( KERN_DEBUG "target %d lun %d: timeout\n", aip->target, aip->lun);
> #endif
Unfortunately this one doesn't fit so much with pr_debug :-(
Domen
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2006-07-31 5:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-31 0:22 [KJ] [PATCH] drivers/block/acsi.c: Add KERN_* to printk statements Richard
2006-07-31 5:38 ` Domen Puncer [this message]
2006-07-31 9:57 ` [KJ] [PATCH] drivers/block/acsi.c: Add KERN_* to printk h.vanberkum
2006-07-31 10:28 ` Domen Puncer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060731053816.GE4969@nd47.coderock.org \
--to=domen@coderock.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.