From: Andi Kleen <ak@suse.de>
To: Chuck Ebbert <76306.1226@compuserve.com>
Cc: Albert Cahalan <acahalan@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [patch] x86_64: fix is_at_popf() for compat tasks
Date: Mon, 31 Jul 2006 10:54:38 +0200 [thread overview]
Message-ID: <200607311054.38585.ak@suse.de> (raw)
In-Reply-To: <200607310325_MC3-1-C691-D76B@compuserve.com>
On Monday 31 July 2006 09:22, Chuck Ebbert wrote:
> When testing for the REX instruction prefix, first check
> for a 32-bit task because in compat mode the REX prefix is an
> increment instruction.
is_compat_task doesn't actually say that a task is in compat mode
(it refers to the Linux compat layer, not x86-64 compat mode)
A better test would be regs->cs == __USER32_CS, but in theory
there could be other code segments in LDT. I guess that can
be ignored though.
-Andi
next prev parent reply other threads:[~2006-07-31 9:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-31 7:22 [patch] x86_64: fix is_at_popf() for compat tasks Chuck Ebbert
2006-07-31 8:54 ` Andi Kleen [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-07-31 16:59 Chuck Ebbert
2006-07-31 20:06 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200607311054.38585.ak@suse.de \
--to=ak@suse.de \
--cc=76306.1226@compuserve.com \
--cc=acahalan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.