All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@us.ibm.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: "Siddha, Suresh B" <suresh.b.siddha@intel.com>,
	Andrew Morton <akpm@osdl.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: synchronous signal in the blocked signal context
Date: Tue, 1 Aug 2006 07:44:03 -0700	[thread overview]
Message-ID: <20060801144403.GA1291@us.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0607312152240.4168@g5.osdl.org>

On Mon, Jul 31, 2006 at 09:54:47PM -0700, Linus Torvalds wrote:
> 
> 
> On Mon, 31 Jul 2006, Siddha, Suresh B wrote:
> >
> > This patch (b0423a0d9cc836b2c3d796623cd19236bfedfe63)
> > 
> > [PATCH] Remove duplicate code in signal.c
> > 
> > reverts a patch introduced by Linus long time back.
> 
> Good catch.
> 
> > Was this intentional?
> > 
> > With the current mainline code, SIGSEGV inside a SIGSEGV handler will endup
> > in linux handling endless recursive faults.
> > 
> > Just wondering if this has been discussed before and is intentional.
> 
> It certainly wasn't discussed, and I don't think it was intentional. We 
> should _not_ just unblock a blocked signal. We should kill the process, 
> because sending the signal is actually very very wrong.
> 
> Paul? Should I just revert, or did you have some deeper reason for it?

I cannot claim any deep thought on this one, so please do revert it.

Next time I submit a patch to code with which I am not intimately
familiar, I clearly need to carefully review the earlier patches.  :-/

							Thanx, Paul

  reply	other threads:[~2006-08-01 14:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-01  2:14 synchronous signal in the blocked signal context Siddha, Suresh B
2006-08-01  4:54 ` Linus Torvalds
2006-08-01 14:44   ` Paul E. McKenney [this message]
2006-08-01 15:25     ` Linus Torvalds
2006-08-01 18:01       ` Siddha, Suresh B
2006-08-01 18:13       ` Paul E. McKenney
2006-08-01 18:13         ` Siddha, Suresh B
2006-08-01 19:01           ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060801144403.GA1291@us.ibm.com \
    --to=paulmck@us.ibm.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=suresh.b.siddha@intel.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.