From: Dave Jones <davej@redhat.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: single bit flip detector.
Date: Tue, 1 Aug 2006 18:30:11 -0400 [thread overview]
Message-ID: <20060801223011.GF22240@redhat.com> (raw)
In-Reply-To: <1154470467.15540.88.camel@localhost.localdomain>
On Tue, Aug 01, 2006 at 11:14:27PM +0100, Alan Cox wrote:
> Ar Maw, 2006-08-01 am 14:44 -0400, ysgrifennodd Dave Jones:
> > + case POISON_FREE ^ 0x01:
> > + case POISON_FREE ^ 0x02:
> > + case POISON_FREE ^ 0x04:
> > + case POISON_FREE ^ 0x08:
> > + case POISON_FREE ^ 0x10:
> > + case POISON_FREE ^ 0x20:
> > + case POISON_FREE ^ 0x40:
> > + case POISON_FREE ^ 0x80:
> > + printk (KERN_ERR "Single bit error detected. Possibly bad RAM.\n");
> > +#ifdef CONFIG_X86
> > + printk (KERN_ERR "Run memtest86 or other memory test tool.\n");
> > +#endif
> > + return;
>
> Gack .. NAK
>
> #1: Do we want memtest86 or memtest86+ ?
I doubt it really matters.
> #2: The check is horrible and there is an elegant implementation for
> single bit.
>
> errors = value ^ expected;
> if (errors && !(errors & (errors - 1)))
> printk(KERN_ERR "Single bit error detected....");
Good call, I'll hack that up.
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2006-08-01 22:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-01 18:44 single bit flip detector Dave Jones
2006-08-01 20:15 ` Bill Davidsen
2006-08-01 22:14 ` Alan Cox
2006-08-01 22:30 ` Dave Jones [this message]
2006-08-01 22:36 ` Dave Jones
2006-08-01 23:00 ` Alexey Dobriyan
2006-08-01 23:16 ` Dave Jones
2006-08-01 23:27 ` Dave Jones
2006-08-01 23:28 ` Andreas Schwab
2006-08-01 23:51 ` Dave Jones
2006-08-02 0:16 ` Dave Jones
2006-08-02 6:20 ` Rolf Eike Beer
2006-08-02 7:08 ` Jan Engelhardt
2006-08-06 11:05 ` Geert Uytterhoeven
2006-08-02 15:24 ` Patrick McLean
2006-08-02 16:12 ` Randy.Dunlap
2006-08-04 21:19 ` Andrew Morton
2006-08-04 22:06 ` Dave Jones
2006-08-04 22:25 ` Andrew Morton
2006-08-04 22:28 ` Dave Jones
2006-08-02 7:08 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060801223011.GF22240@redhat.com \
--to=davej@redhat.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.