All of lore.kernel.org
 help / color / mirror / Atom feed
From: wcheng@sourceware.org <wcheng@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/gfs-kernel/src/gfs super.c
Date: 2 Aug 2006 01:28:59 -0000	[thread overview]
Message-ID: <20060802012859.31428.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/cluster
Module name:	cluster
Branch: 	RHEL4
Changes by:	wcheng at sourceware.org	2006-08-02 01:28:57

Modified files:
	gfs-kernel/src/gfs: super.c 

Log message:
	Bugzilla 199984: Increasing gt_statfs_slots tunable could significantly
	boost gfs "df" performance; e.g. set it to 128 from current default (64)
	could cut the "df" wall time in half with larger filesystem size. However,
	the kmalloc call within stat_gfs_async() has the possibility to fail due
	to increased gt_statfs_slots. There is really no need for this array to
	be on a piece of contiguous memory. Switch to vmalloc().

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/super.c.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.12.2.3&r2=1.12.2.4

--- cluster/gfs-kernel/src/gfs/super.c	2006/02/15 17:19:22	1.12.2.3
+++ cluster/gfs-kernel/src/gfs/super.c	2006/08/02 01:28:57	1.12.2.4
@@ -840,7 +840,7 @@
 
 	memset(sg, 0, sizeof(struct gfs_stat_gfs));
 
-	gha = kmalloc(slots * sizeof(struct gfs_holder), GFP_KERNEL);
+	gha = vmalloc(slots * sizeof(struct gfs_holder));
 	if (!gha)
 		return -ENOMEM;
 	memset(gha, 0, slots * sizeof(struct gfs_holder));
@@ -884,7 +884,7 @@
 		yield();
 	}
 
-	kfree(gha);
+	vfree(gha);
 
 	return error;
 }



             reply	other threads:[~2006-08-02  1:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-02  1:28 wcheng [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-08-02  1:37 [Cluster-devel] cluster/gfs-kernel/src/gfs super.c wcheng
2006-08-09 20:28 rpeterso
2006-09-20  4:45 wcheng
2007-02-06 22:08 wcheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060802012859.31428.qmail@sourceware.org \
    --to=wcheng@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.