All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: netdev@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] Fix more per-cpu typos
Date: Wed, 2 Aug 2006 05:02:11 +0200	[thread overview]
Message-ID: <200608020502.11274.ak@suse.de> (raw)
In-Reply-To: <20060801232333.GC14863@martell.zuzino.mipt.ru>


> --- a/arch/x86_64/kernel/smp.c
> +++ b/arch/x86_64/kernel/smp.c
> @@ -203,7 +203,7 @@ int __cpuinit init_smp_flush(void)
>  {
>  	int i;
>  	for_each_cpu_mask(i, cpu_possible_map) {
> -		spin_lock_init(&per_cpu(flush_state.tlbstate_lock, i));
> +		spin_lock_init(&per_cpu(flush_state, i).tlbstate_lock);

What advantage does this have over the earlier form?

In general this should be split up into three patches.

-Andi

  reply	other threads:[~2006-08-02  3:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-01 23:23 [PATCH] Fix more per-cpu typos Alexey Dobriyan
2006-08-02  3:02 ` Andi Kleen [this message]
2006-08-02 15:26   ` Alexey Dobriyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200608020502.11274.ak@suse.de \
    --to=ak@suse.de \
    --cc=adobriyan@gmail.com \
    --cc=akpm@osdl.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.