Re: advansys pci tweaks.

[Matthew Wilcox <matthew@wil.cx>]

On Wed, Aug 02, 2006 at 05:11:49PM -0400, Dave Jones wrote:
> Remove a lot of duplicate #defines from the advansys driver,
> and make them look like PCI IDs as defined elsewhere in the kernel.
> Also add a module table so that it automatically gets picked up
> by tools relying on modinfo output (like say, distro installers).

I'd much rather see at least the vendor ID moved to pci_ids.h; how about
#define PCI_VENDOR_ID_ADVSYS            0x10cd
for that one?

> @@ -889,10 +889,6 @@ typedef unsigned char uchar;
>  #define ASC_PCI_ID2DEV(id)    (((id) >> 11) & 0x1F)
>  #define ASC_PCI_ID2FUNC(id)   (((id) >> 8) & 0x7)
>  #define ASC_PCI_MKID(bus, dev, func) ((((dev) & 0x1F) << 11) | (((func) & 0x7) << 8) | ((bus) & 0xFF))

... those all need to be fixed too.  Sigh.  I wonder if Bob Frey is
still around to care about this driver ...