From: Dave Jones <davej@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, jbaron@redhat.com
Subject: Re: frequent slab corruption (since a long time)
Date: Wed, 2 Aug 2006 18:23:21 -0400 [thread overview]
Message-ID: <20060802222321.GH3639@redhat.com> (raw)
In-Reply-To: <20060801.223110.56811869.davem@davemloft.net>
On Tue, Aug 01, 2006 at 10:31:10PM -0700, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Tue, 01 Aug 2006 22:05:38 -0700 (PDT)
>
> > The corruption is always a 32-bit 0xffffffff followed by
> > a 32-bit 0x00000000, 12 bytes into the object.
>
> This analysis is wrong, it's "0xb0 + 12" bytes into the object
> which is 188 bytes. For x86, this lands us at the "count"
> member of the tty_struct, and it shows that the tty count
> has decremented to -1 (0xffffffff) which is a serious bug.
<stabbing in the dark here>
None of the code manipulating tty->count seems to be under
the tty_mutex. Should it be ?
Or is this protected through some other means?
Jason, ISTR you've done some digging around this area wrt races,
any insight ?
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2006-08-02 22:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-02 2:16 frequent slab corruption (since a long time) Dave Jones
2006-08-02 2:34 ` Roland Dreier
2006-08-02 3:37 ` Andi Kleen
2006-08-02 4:22 ` Dave Jones
2006-08-02 4:35 ` Andi Kleen
2006-08-02 4:46 ` Dave Jones
2006-08-02 5:05 ` David Miller
2006-08-02 5:31 ` David Miller
2006-08-02 22:23 ` Dave Jones [this message]
2006-08-02 22:49 ` David Miller
2006-08-03 17:40 ` Alan Cox
2006-08-03 17:56 ` Dave Jones
2006-08-03 20:48 ` Alan Cox
2006-08-02 23:14 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060802222321.GH3639@redhat.com \
--to=davej@redhat.com \
--cc=davem@davemloft.net \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.