All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars Ellenberg <Lars.Ellenberg@linbit.com>
To: drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] Re: reboot notifier
Date: Thu, 3 Aug 2006 12:33:14 +0200	[thread overview]
Message-ID: <20060803103314.GG4643@soda.linbit> (raw)
In-Reply-To: <1154593867.2335.20.camel@shadowfox.linsyssoft.com>

/ 2006-08-03 14:01:07 +0530
\ Milind Dumbare:
> 	My point was code structuring. As this is the way reboot notifiers are
> written. But for doing interesting things in notify functions, it will
> be nice to have switch cases structured, rather than writing function
> which is doing nothing.

great. having switch statements which do the wrong thing is good,
because the code is more nicely structured. wow.
don't get me wrong. I put that function there, so once we know something
"interessting" that we want/need to do on reboot, I don't need to
remember how to implement those notifiers.

but before we put some functional code in there, maybe we should first
figure out what those "interesting things" are, that we want/need to do
on notification.

I'm open for suggestions.
however, just calling drbd_cleanup there unconditionally is not useful.

-- 
: Lars Ellenberg                                  Tel +43-1-8178292-55 :
: LINBIT Information Technologies GmbH            Fax +43-1-8178292-82 :
: Schoenbrunner Str. 244, A-1120 Vienna/Europe   http://www.linbit.com :

      parent reply	other threads:[~2006-08-03 10:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.93.1154590245.4693.drbd-dev@lists.linbit.com>
2006-08-03  8:20 ` [Drbd-dev] Re: reboot notifier Lars Ellenberg
     [not found]   ` <1154593867.2335.20.camel@shadowfox.linsyssoft.com>
2006-08-03 10:33     ` Lars Ellenberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060803103314.GG4643@soda.linbit \
    --to=lars.ellenberg@linbit.com \
    --cc=drbd-dev@lists.linbit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.