* don't taint UP K7's running SMP kernels.
@ 2006-08-03 18:32 Dave Jones
2006-08-03 21:04 ` Alan Cox
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Dave Jones @ 2006-08-03 18:32 UTC (permalink / raw)
To: Linux Kernel
We have a test that looks for invalid pairings of certain athlon/durons
that weren't designed for SMP, and taint accordingly (with 'S') if we find
such a configuration. However, this test shouldn't fire if there's only
a single CPU present. It's perfectly valid for an SMP kernel to boot on UP
hardware for example.
Signed-off-by: Dave Jones <davej@redhat.com>
--- linux-2.6/arch/i386/kernel/smpboot.c~ 2006-08-03 14:29:47.000000000 -0400
+++ linux-2.6/arch/i386/kernel/smpboot.c 2006-08-03 14:30:43.000000000 -0400
@@ -177,6 +177,9 @@ static void __devinit smp_store_cpu_info
*/
if ((c->x86_vendor == X86_VENDOR_AMD) && (c->x86 == 6)) {
+ if (num_online_cpus() == 1)
+ goto valid_k7;
+
/* Athlon 660/661 is valid. */
if ((c->x86_model==6) && ((c->x86_mask==0) || (c->x86_mask==1)))
goto valid_k7;
--
http://www.codemonkey.org.uk
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: don't taint UP K7's running SMP kernels.
2006-08-03 18:32 don't taint UP K7's running SMP kernels Dave Jones
@ 2006-08-03 21:04 ` Alan Cox
2006-08-04 0:53 ` Andi Kleen
2006-08-04 0:55 ` don't taint UP K7's running SMP kernels. II Andi Kleen
2 siblings, 0 replies; 4+ messages in thread
From: Alan Cox @ 2006-08-03 21:04 UTC (permalink / raw)
To: Dave Jones; +Cc: Linux Kernel
Ar Iau, 2006-08-03 am 14:32 -0400, ysgrifennodd Dave Jones:
> We have a test that looks for invalid pairings of certain athlon/durons
> that weren't designed for SMP, and taint accordingly (with 'S') if we find
> such a configuration. However, this test shouldn't fire if there's only
> a single CPU present. It's perfectly valid for an SMP kernel to boot on UP
> hardware for example.
>
> Signed-off-by: Dave Jones <davej@redhat.com>
>
> --- linux-2.6/arch/i386/kernel/smpboot.c~ 2006-08-03 14:29:47.000000000 -0400
> +++ linux-2.6/arch/i386/kernel/smpboot.c 2006-08-03 14:30:43.000000000 -0400
> @@ -177,6 +177,9 @@ static void __devinit smp_store_cpu_info
> */
> if ((c->x86_vendor == X86_VENDOR_AMD) && (c->x86 == 6)) {
>
> + if (num_online_cpus() == 1)
> + goto valid_k7;
> +
> /* Athlon 660/661 is valid. */
> if ((c->x86_model==6) && ((c->x86_mask==0) || (c->x86_mask==1)))
> goto valid_k7;
Acked-by: Alan Cox <alan@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: don't taint UP K7's running SMP kernels.
2006-08-03 18:32 don't taint UP K7's running SMP kernels Dave Jones
2006-08-03 21:04 ` Alan Cox
@ 2006-08-04 0:53 ` Andi Kleen
2006-08-04 0:55 ` don't taint UP K7's running SMP kernels. II Andi Kleen
2 siblings, 0 replies; 4+ messages in thread
From: Andi Kleen @ 2006-08-04 0:53 UTC (permalink / raw)
To: Dave Jones; +Cc: linux-kernel
Dave Jones <davej@redhat.com> writes:
> We have a test that looks for invalid pairings of certain athlon/durons
> that weren't designed for SMP, and taint accordingly (with 'S') if we find
> such a configuration. However, this test shouldn't fire if there's only
> a single CPU present. It's perfectly valid for an SMP kernel to boot on UP
> hardware for example.
I added it to the x86-64 tree.
-Andi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: don't taint UP K7's running SMP kernels. II
2006-08-03 18:32 don't taint UP K7's running SMP kernels Dave Jones
2006-08-03 21:04 ` Alan Cox
2006-08-04 0:53 ` Andi Kleen
@ 2006-08-04 0:55 ` Andi Kleen
2 siblings, 0 replies; 4+ messages in thread
From: Andi Kleen @ 2006-08-04 0:55 UTC (permalink / raw)
To: Dave Jones; +Cc: linux-kernel
Dave Jones <davej@redhat.com> writes:
> We have a test that looks for invalid pairings of certain athlon/durons
> that weren't designed for SMP, and taint accordingly (with 'S') if we find
> such a configuration. However, this test shouldn't fire if there's only
> a single CPU present. It's perfectly valid for an SMP kernel to boot on UP
> hardware for example.
Actually the test should be for num_possible_cpus() I fixed this.
-Andi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-08-04 0:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-03 18:32 don't taint UP K7's running SMP kernels Dave Jones
2006-08-03 21:04 ` Alan Cox
2006-08-04 0:53 ` Andi Kleen
2006-08-04 0:55 ` don't taint UP K7's running SMP kernels. II Andi Kleen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.