[PATCH] fix git-revert command-line options

[PATCH] fix git-revert command-line options

[Michael]

Signed-off-by: Michael <barra_cuda@katamail.com>
---
 git-revert.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/git-revert.sh b/git-revert.sh
index 2bf35d1..195c3ba 100755
--- a/git-revert.sh
+++ b/git-revert.sh
@@ -22,14 +22,14 @@ no_commit= replay=
 while case "$#" in 0) break ;; esac
 do
 	case "$1" in
-	-n|--n|--no|--no-|--no-c|--no-co|--no-com|--no-comm|\
+	-n|--no-c|--no-co|--no-com|--no-comm|\
 	    --no-commi|--no-commit)
 		no_commit=t
 		;;
 	-e|--e|--ed|--edi|--edit)
 		edit=-e
 		;;
-	--n|--no|--no-|--no-e|--no-ed|--no-edi|--no-edit)
+	--n|--no-e|--no-ed|--no-edi|--no-edit)
 		edit=
 		;;
 	-r|--r|--re|--rep|--repl|--repla|--replay)
-- 
1.4.1

[PATCH] fix git-revert command-line options

[Michael]

Signed-off-by: Michael <barra_cuda@katamail.com>
---
 git-revert.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/git-revert.sh b/git-revert.sh
index 2bf35d1..195c3ba 100755
--- a/git-revert.sh
+++ b/git-revert.sh
@@ -22,14 +22,14 @@ no_commit= replay=
 while case "$#" in 0) break ;; esac
 do
 	case "$1" in
-	-n|--n|--no|--no-|--no-c|--no-co|--no-com|--no-comm|\
+	-n|--no-c|--no-co|--no-com|--no-comm|\
 	    --no-commi|--no-commit)
 		no_commit=t
 		;;
 	-e|--e|--ed|--edi|--edit)
 		edit=-e
 		;;
-	--n|--no|--no-|--no-e|--no-ed|--no-edi|--no-edit)
+	--n|--no-e|--no-ed|--no-edi|--no-edit)
 		edit=
 		;;
 	-r|--r|--re|--rep|--repl|--repla|--replay)
-- 
1.4.1

Re: [PATCH] fix git-revert command-line options

[Martin Waitz]

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

hoi :)

On Thu, Aug 03, 2006 at 05:42:23PM +0200, Michael wrote:
> -	-n|--n|--no|--no-|--no-c|--no-co|--no-com|--no-comm|\
> +	-n|--no-c|--no-co|--no-com|--no-comm|\

> -	--n|--no|--no-|--no-e|--no-ed|--no-edi|--no-edit)
> +	--n|--no-e|--no-ed|--no-edi|--no-edit)

well spottet, but now we still have "-n" versus "--n".
Perhaps we should drop the single-letter options or at least only
keep one of them and then explicitly document that in the manpage.

-- 
Martin Waitz

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH] fix git-revert command-line options

[Junio C Hamano]

Martin Waitz <tali@admingilde.org> writes:

> On Thu, Aug 03, 2006 at 05:42:23PM +0200, Michael wrote:
>> -	-n|--n|--no|--no-|--no-c|--no-co|--no-com|--no-comm|\
>> +	-n|--no-c|--no-co|--no-com|--no-comm|\
>
>> -	--n|--no|--no-|--no-e|--no-ed|--no-edi|--no-edit)
>> +	--n|--no-e|--no-ed|--no-edi|--no-edit)
>
> well spottet, but now we still have "-n" versus "--n".
> Perhaps we should drop the single-letter options or at least only
> keep one of them and then explicitly document that in the manpage.

Good suggestion.

Re: [PATCH] fix git-revert command-line options

[Michael]

Junio C Hamano wrote:
> Martin Waitz <tali@admingilde.org> writes:
> > On Thu, Aug 03, 2006 at 05:42:23PM +0200, Michael wrote:
> >> -	-n|--n|--no|--no-|--no-c|--no-co|--no-com|--no-comm|\
> >> +	-n|--no-c|--no-co|--no-com|--no-comm|\
> >>
> >> -	--n|--no|--no-|--no-e|--no-ed|--no-edi|--no-edit)
> >> +	--n|--no-e|--no-ed|--no-edi|--no-edit)
> >
> > well spottet, but now we still have "-n" versus "--n".
> > Perhaps we should drop the single-letter options or at least only
> > keep one of them and then explicitly document that in the manpage.
>
> Good suggestion.

Well, I left "--n" for the lazy typers, but it's too confusing - and
can be easy misremembered. I'd leave "-n" for "--no-commit", though
(and it's already on man page).
Your choice.

Re: [PATCH] fix git-revert command-line options

[Michael]

Junio C Hamano wrote:
> Martin Waitz <tali@admingilde.org> writes:
> > On Thu, Aug 03, 2006 at 05:42:23PM +0200, Michael wrote:
> >> -	-n|--n|--no|--no-|--no-c|--no-co|--no-com|--no-comm|\
> >> +	-n|--no-c|--no-co|--no-com|--no-comm|\
> >>
> >> -	--n|--no|--no-|--no-e|--no-ed|--no-edi|--no-edit)
> >> +	--n|--no-e|--no-ed|--no-edi|--no-edit)
> >
> > well spottet, but now we still have "-n" versus "--n".
> > Perhaps we should drop the single-letter options or at least only
> > keep one of them and then explicitly document that in the manpage.
>
> Good suggestion.

Well, I left "--n" for the lazy typers, but it's too confusing - and
can be easy misremembered. I'd leave "-n" for "--no-commit", though
(and it's already on man page).
Your choice.