All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Aravamudan <nacc@us.ibm.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] Use kzalloc
Date: Thu, 03 Aug 2006 21:12:16 +0000	[thread overview]
Message-ID: <20060803211216.GB6253@us.ibm.com> (raw)
In-Reply-To: <11546380282929-git-send-email-tom_hisch@gmx.at>

On 03.08.2006 [22:47:08 +0200], tom_hisch@gmx.at wrote:
> From: Thomas Hisch <t.hisch@gmail.com>
> 
> use kzalloc in include/asm-i386/thread_info.h instead of kmalloc + memset
> 
> Signed-off-by: Thomas Hisch <t.hisch@gmail.com>
> ---
>  include/asm-i386/thread_info.h |    5 +----
>  1 files changed, 1 insertions(+), 4 deletions(-)
> 
> diff --git a/include/asm-i386/thread_info.h b/include/asm-i386/thread_info.h
> index 54d6d7a..a8f37f2 100644
> --- a/include/asm-i386/thread_info.h
> +++ b/include/asm-i386/thread_info.h
> @@ -32,7 +32,6 @@ struct thread_info {
>  	__u32			cpu;		/* current CPU */
>  	int			preempt_count;	/* 0 => preemptable, <0 => BUG */
>  
> -
Looks like an unrelated change sneaked in.

Thanks,
Nish

>  	mm_segment_t		addr_limit;	/* thread address space:
>  					 	   0-0xBFFFFFFF for user-thead
>  						   0-0xFFFFFFFF for kernel-thread
> @@ -99,9 +98,7 @@ #define alloc_thread_info(tsk)					\
>  	({							\
>  		struct thread_info *ret;			\
>  								\
> -		ret = kmalloc(THREAD_SIZE, GFP_KERNEL);		\
> -		if (ret)					\
> -			memset(ret, 0, THREAD_SIZE);		\
> +		ret = kzalloc(THREAD_SIZE, GFP_KERNEL);		\
>  		ret;						\
>  	})
>  #else
> -- 
> 1.4.2.rc1.gbc9e-dirty
> 
> 
> 
> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.osdl.org
> https://lists.osdl.org/mailman/listinfo/kernel-janitors
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

  reply	other threads:[~2006-08-03 21:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-03 20:47 [KJ] [PATCH] Use kzalloc tom_hisch
2006-08-03 21:12 ` Nishanth Aravamudan [this message]
2006-08-03 21:29 ` Bernd Petrovitsch
2006-08-07 10:50 ` tom_hisch
2006-08-07 11:45 ` walter harms
2006-08-13 11:00 ` tom hisch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060803211216.GB6253@us.ibm.com \
    --to=nacc@us.ibm.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.