From: Greg KH <greg@kroah.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, stable@kernel.org
Subject: Re: [stable] [PATCH] llc: SOCK_DGRAM interface fixes
Date: Thu, 3 Aug 2006 14:52:17 -0700 [thread overview]
Message-ID: <20060803215217.GA21836@kroah.com> (raw)
In-Reply-To: <20060803092117.5726b4d7@localhost.localdomain>
On Thu, Aug 03, 2006 at 09:21:17AM -0700, Stephen Hemminger wrote:
> The datagram interface of LLC is broken in a couple of ways.
> These were discovered when trying to use it to build an out-of-kernel
> version of STP.
>
> First it didn't pass the source address of the received packet
> in recvfrom(). It needs to copy the source address of received LLC packets
> into the socket control block. At the same time fix a security issue
> because there was uninitialized data leakage. Every recvfrom call
> was just copying out old data.
>
> Second, LLC should not merge multiple packets in one receive call
> on datagram sockets. LLC should preserve packet boundaries on
> SOCK_DGRAM.
>
> This fix goes against the old historical comments about UNIX98 semantics
> but without this fix SOCK_DGRAM is broken and useless. So either ANK's
> interpretation was incorect or UNIX98 standard was wrong.
This doesn't apply at all to the current -stable tree, sorry.
greg k-h
next prev parent reply other threads:[~2006-08-03 21:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-03 16:21 [PATCH] llc: SOCK_DGRAM interface fixes Stephen Hemminger
2006-08-03 16:38 ` Arnaldo Carvalho de Melo
2006-08-03 23:39 ` David Miller
2006-08-03 21:52 ` Greg KH [this message]
2006-08-08 16:36 ` Alexey Kuznetsov
2006-08-08 16:42 ` Stephen Hemminger
2006-08-08 17:54 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060803215217.GA21836@kroah.com \
--to=greg@kroah.com \
--cc=acme@ghostprotocols.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.