From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, stable@kernel.org,
Arjan van de Ven <arjan@infradead.org>
Cc: Justin Forbes <jmforbes@linuxtx.org>,
Zwane Mwaikambo <zwane@arm.linux.org.uk>,
"Theodore Ts'o" <tytso@mit.edu>,
Randy Dunlap <rdunlap@xenotime.net>,
Dave Jones <davej@redhat.com>,
Chuck Wolber <chuckw@quantumlinux.com>,
Chris Wedgwood <reviews@ml.cw.f00f.org>,
torvalds@osdl.org, akpm@osdl.org, alan@lxorguk.ukuu.org.uk,
David Lang <dlang@digitalinsight.com>,
Andrew de Quincey <adq_dvb@lidskialf.net>,
Michael Krufky <mkrufky@linuxtv.org>,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: [patch 19/23] Fix budget-av compile failure
Date: Thu, 3 Aug 2006 22:40:32 -0700 [thread overview]
Message-ID: <20060804054032.GT769@kroah.com> (raw)
In-Reply-To: <20060804053807.GA769@kroah.com>
[-- Attachment #1: fix-budget-av-compile-failure.patch --]
[-- Type: text/plain, Size: 2143 bytes --]
-stable review patch. If anyone has any objections, please let us know.
------------------
From: Andrew de Quincey <adq_dvb@lidskialf.net>
Currently I am doing lots of refactoring work in the dvb tree. This
bugfix became necessary to fix 2.6.17 whilst I was in the middle of this
work. Unfortunately after I tested the original code for the patch, I
generated the diff against the wrong tree (I accidentally used a tree
with part of the refactoring code in it). This resulted in the reported
compile errors because that tree (a) was incomplete, and (b) used
features which are simply not in the mainline kernel yet.
Many apologies for the error and problems this has caused. :(
Signed-off-by: Andrew de Quincey <adq_dvb@lidskialf.net>
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/media/dvb/ttpci/budget-av.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
--- linux-2.6.17.7.orig/drivers/media/dvb/ttpci/budget-av.c
+++ linux-2.6.17.7/drivers/media/dvb/ttpci/budget-av.c
@@ -58,6 +58,7 @@ struct budget_av {
struct tasklet_struct ciintf_irq_tasklet;
int slot_status;
struct dvb_ca_en50221 ca;
+ u8 reinitialise_demod:1;
};
/* GPIO Connections:
@@ -214,8 +215,9 @@ static int ciintf_slot_reset(struct dvb_
while (--timeout > 0 && ciintf_read_attribute_mem(ca, slot, 0) != 0x1d)
msleep(100);
- /* reinitialise the frontend */
- dvb_frontend_reinitialise(budget_av->budget.dvb_frontend);
+ /* reinitialise the frontend if necessary */
+ if (budget_av->reinitialise_demod)
+ dvb_frontend_reinitialise(budget_av->budget.dvb_frontend);
if (timeout <= 0)
{
@@ -1064,12 +1066,10 @@ static void frontend_init(struct budget_
fe = tda10021_attach(&philips_cu1216_config,
&budget_av->budget.i2c_adap,
read_pwm(budget_av));
- if (fe) {
- fe->ops.tuner_ops.set_params = philips_cu1216_tuner_set_params;
- }
break;
case SUBID_DVBC_KNC1_PLUS:
+ budget_av->reinitialise_demod = 1;
fe = tda10021_attach(&philips_cu1216_config,
&budget_av->budget.i2c_adap,
read_pwm(budget_av));
--
next prev parent reply other threads:[~2006-08-04 5:47 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060804053258.391158155@quad.kroah.org>
2006-08-04 5:38 ` [patch 00/23] -stable review Greg KH
2006-08-04 5:38 ` [patch 01/23] PCI: fix issues with extended conf space when MMCONFIG disabled because of e820 Greg KH
2006-08-04 5:38 ` [patch 02/23] Dont allow chmod() on the /proc/<pid>/ files Greg KH
2006-08-04 5:38 ` [patch 03/23] : H.323 helper: fix possible NULL-ptr dereference Greg KH
2006-08-04 5:38 ` [patch 04/23] scx200_acb: Fix the state machine Greg KH
2006-08-04 5:38 ` [patch 05/23] scx200_acb: Fix the block transactions Greg KH
2006-08-04 5:38 ` [patch 06/23] i2c: Fix ignore module parameter handling in i2c-core Greg KH
2006-08-04 5:39 ` [patch 07/23] sky2: NAPI bug Greg KH
2006-08-04 5:39 ` [patch 08/23] UHCI: Fix handling of short last packet Greg KH
2006-08-04 5:39 ` [patch 09/23] : Update frag_list in pskb_trim Greg KH
2006-08-04 5:39 ` [patch 10/23] VLAN state handling fix Greg KH
2006-08-04 5:39 ` [patch 11/23] Sparc64 quad-float emulation fix Greg KH
2006-08-04 5:39 ` [patch 12/23] invalidate_bdev() speedup Greg KH
2006-08-04 8:50 ` Christoph Hellwig
2006-08-04 9:04 ` Andrew Morton
2006-08-04 13:08 ` Arjan van de Ven
2006-08-04 13:25 ` Jes Sorensen
2006-08-04 15:18 ` Andrew Morton
2006-08-04 5:39 ` [patch 13/23] ieee1394: sbp2: enable auto spin-up for Maxtor disks Greg KH
2006-08-04 5:39 ` [patch 14/23] Fix race related problem when adding items to and svcrpc auth cache Greg KH
2006-08-04 5:39 ` Greg KH
2006-08-04 5:40 ` [patch 15/23] ext3 -nobh option causes oops Greg KH
2006-11-16 22:51 ` Adrian Bunk
2006-11-16 23:07 ` Badari Pulavarty
2006-11-17 16:47 ` Adrian Bunk
2006-08-04 5:40 ` [patch 16/23] ext3: avoid triggering ext3_error on bad NFS file handle Greg KH
2006-08-04 14:45 ` Eric Sandeen
2006-08-04 14:52 ` Christoph Hellwig
2006-08-04 15:35 ` Eric Sandeen
2006-08-05 1:28 ` Theodore Tso
2006-08-10 5:38 ` [stable] " Greg KH
2006-08-04 5:40 ` [patch 17/23] e1000: add forgotten PCI ID for supported device Greg KH
2006-08-04 5:40 ` [patch 18/23] cond_resched() fix Greg KH
2006-08-04 5:40 ` Greg KH [this message]
2006-08-04 5:40 ` [patch 20/23] S390: fix futex_atomic_cmpxchg_inatomic Greg KH
2006-08-07 8:39 ` Martin Schwidefsky
2006-08-04 5:40 ` [patch 21/23] tty serialize flush_to_ldisc Greg KH
2006-08-04 5:40 ` [patch 22/23] Add stable branch to maintainers file Greg KH
2006-08-04 5:41 ` [patch 23/23] Have ext2 reject file handles with bad inode numbers early Greg KH
2006-08-04 7:18 ` [patch 00/23] -stable review Grant Coady
2006-08-04 7:20 ` Greg KH
2006-08-04 9:04 ` Jesper Juhl
2006-08-04 9:10 ` Patrick McHardy
2006-08-04 9:19 ` Jesper Juhl
2006-08-04 9:24 ` Patrick McHardy
2006-08-04 9:31 ` Jesper Juhl
2006-08-04 9:19 ` Andrew Morton
2006-08-04 9:22 ` Jesper Juhl
2006-08-04 13:50 ` Auke Kok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060804054032.GT769@kroah.com \
--to=gregkh@suse.de \
--cc=adq_dvb@lidskialf.net \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arjan@infradead.org \
--cc=chuckw@quantumlinux.com \
--cc=davej@redhat.com \
--cc=dlang@digitalinsight.com \
--cc=jmforbes@linuxtx.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkrufky@linuxtv.org \
--cc=rdunlap@xenotime.net \
--cc=reviews@ml.cw.f00f.org \
--cc=stable@kernel.org \
--cc=torvalds@osdl.org \
--cc=tytso@mit.edu \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.