From: Pavel Machek <pavel@ucw.cz>
To: Andrew Morton <akpm@osdl.org>
Cc: Rolf Eike Beer <eike-kernel@sf-tec.de>,
trivial@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Use BUG_ON(foo) instead of "if (foo) BUG()" in include/asm-i386/dma-mapping.h
Date: Sat, 5 Aug 2006 11:37:04 +0000 [thread overview]
Message-ID: <20060805113703.GD4506@ucw.cz> (raw)
In-Reply-To: <20060728004758.5e7c5120.akpm@osdl.org>
Hi!
> > We have BUG_ON() right for this, don't we?
>
> Well yes, but there are over a thousand BUG->BUG_ON conversion
> possibilities in the tree. If people start sending them three-at-a-time
> we'll all go mad.
>
> So. If we're going to do this, bigger patches, please.
If we are going that way... I guess we should specify if BUG_ON() has
to evaluate its arguments even if it is compiled out...
Or probably better pecify that BUG_ON() must not have side effects?
Pavel
--
Thanks for all the (sleeping) penguins.
next prev parent reply other threads:[~2006-08-06 22:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-28 7:28 [PATCH] Use BUG_ON(foo) instead of "if (foo) BUG()" in include/asm-i386/dma-mapping.h Rolf Eike Beer
2006-07-28 7:47 ` Andrew Morton
2006-08-05 11:37 ` Pavel Machek [this message]
2006-08-07 1:20 ` Adrian Bunk
2006-07-28 17:44 ` Muli Ben-Yehuda
2006-08-02 15:20 ` [PATCH] Move valid_dma_direction() from x86_64 to generic code Rolf Eike Beer
2006-08-02 18:55 ` Muli Ben-Yehuda
2006-08-03 6:25 ` Rolf Eike Beer
2006-08-03 7:23 ` Muli Ben-Yehuda
2006-08-03 21:10 ` IOMMU (Calgary) patches Duran, Leo
2006-08-03 21:25 ` Jon Mason
2006-08-03 21:35 ` Duran, Leo
2006-08-03 22:46 ` [discuss] " Andi Kleen
2006-08-02 15:22 ` [PATCH] Use valid_dma_direction() in include/asm-i386/dma-mapping.h Rolf Eike Beer
2006-08-02 18:56 ` Muli Ben-Yehuda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060805113703.GD4506@ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@osdl.org \
--cc=eike-kernel@sf-tec.de \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.