All of lore.kernel.org
 help / color / mirror / Atom feed
From: linux-kernel@hansmi.ch (Michael Hanselmann)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] [PATCH] Apple Motion Sensor driver
Date: Sun, 06 Aug 2006 14:38:38 +0000	[thread overview]
Message-ID: <20060806143838.GA3208@hansmi.ch> (raw)
In-Reply-To: <20060802191520.GA2260@hansmi.ch>

On Sun, Aug 06, 2006 at 01:41:02PM +0200, Johannes Berg wrote:
> On Wed, 2006-08-02 at 21:15 +0200, Michael Hanselmann wrote:
> I'm not sure if that's possible to solve at all.

I think it is, see patch below. However, the solution is not that
pretty.

> 	depends on HWMON && PPC_PMAC && INPUT && ADB_PMU && I2C && EXPERIMENTAL

This would not allow users to build the AMS stuff without having I2C in
he kernel -- which is not really required.

What do you think about this patch?

---
diff -Nrup --exclude-from linux-exclude-from linux-2.6.18-rc3.orig/drivers/hwmon/Kconfig linux-2.6.18-rc3/drivers/hwmon/Kconfig
--- linux-2.6.18-rc3.orig/drivers/hwmon/Kconfig	2006-08-06 14:26:13.000000000 +0200
+++ linux-2.6.18-rc3/drivers/hwmon/Kconfig	2006-08-06 16:31:11.000000000 +0200
@@ -96,12 +96,14 @@ config SENSORS_ADM9240
 
 config SENSORS_AMS
 	tristate "Apple Motion Sensor driver"
-	depends on HWMON && PPC_PMAC && INPUT && EXPERIMENTAL
-	default y
+	depends on HWMON && PPC_PMAC && !PPC64 && INPUT && ((ADB_PMU && I2C = y) || (ADB_PMU && !I2C) || I2C) && EXPERIMENTAL
 	help
 	  Support for the motion sensor included in PowerBooks. Includes
 	  implementations for PMU and I2C.
 
+	  This driver can also be built as a module. If so, the module
+	  will be called ams.
+
 config SENSORS_AMS_PMU
 	bool "PMU variant"
 	depends on SENSORS_AMS && ADB_PMU
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20060806/51eddd2b/attachment.bin 

  parent reply	other threads:[~2006-08-06 14:38 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-02 19:15 [lm-sensors] [PATCH] Apple Motion Sensor driver Michael Hanselmann
2006-08-03  2:11 ` Andrew Morton
2006-08-03  6:53 ` Michael Hanselmann
2006-08-03  7:26 ` Andrew Morton
2006-08-03  7:36 ` Andrew Morton
2006-08-03 19:49 ` Michael Hanselmann
2006-08-03 20:08 ` Aristeu Sergio Rozanski Filho
2006-08-04  8:13 ` Johannes Berg
2006-08-04  8:34 ` Johannes Berg
2006-08-04 14:11 ` Aristeu Sergio Rozanski Filho
2006-08-04 19:52 ` Michael Hanselmann
2006-08-04 20:39 ` Aristeu Sergio Rozanski Filho
2006-08-04 21:49 ` Michael Hanselmann
2006-08-04 22:19 ` Andrew Morton
2006-08-04 23:03 ` Michael Hanselmann
2006-08-05  7:26 ` Stelian Pop
2006-08-06 11:41 ` Johannes Berg
2006-08-06 14:38 ` Michael Hanselmann [this message]
2006-08-07  7:09 ` Johannes Berg
2006-08-07  8:02 ` Jean Delvare
2006-08-07  8:06 ` Johannes Berg
2006-08-07  9:28 ` Jean Delvare
2006-08-07  9:36 ` Johannes Berg
2006-08-09 10:07 ` Benjamin Herrenschmidt
2006-08-09 10:37 ` Benjamin Herrenschmidt
2006-08-09 12:17 ` Michael Hanselmann
2006-08-09 12:25 ` Johannes Berg
2006-08-09 12:39 ` Johannes Berg
2006-08-10 18:33 ` Michael Hanselmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060806143838.GA3208@hansmi.ch \
    --to=linux-kernel@hansmi.ch \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.