From: David Miller <davem@davemloft.net>
To: jesse.brandeburg@gmail.com
Cc: herbert@gondor.apana.org.au, johnpol@2ka.mipt.ru,
netdev@vger.kernel.org, chris.leech@gmail.com,
jesse.brandeburg@intel.com
Subject: Re: [RFC] avoid unnecessary alignement overhead in skb->data allocation.
Date: Mon, 07 Aug 2006 17:41:42 -0700 (PDT) [thread overview]
Message-ID: <20060807.174142.88474584.davem@davemloft.net> (raw)
In-Reply-To: <4807377b0608071709j26da1092la20f1589c7b90df7@mail.gmail.com>
From: "Jesse Brandeburg" <jesse.brandeburg@gmail.com>
Date: Mon, 7 Aug 2006 17:09:39 -0700
> also, eth_type_trans wants skb->data to point to header, which would
> require us to memcpy data from a page back to skb->data.
You merely would need to call pskb_may_pull() right before invoking
eth_type_trans. Meeting that functions expectations with a non-linear
SKB is not brain surgery. :-)
next prev parent reply other threads:[~2006-08-08 0:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-07 6:01 [RFC] avoid unnecessary alignement overhead in skb->data allocation Evgeniy Polyakov
2006-08-07 6:23 ` David Miller
2006-08-07 6:30 ` Evgeniy Polyakov
2006-08-07 7:17 ` Herbert Xu
2006-08-07 7:24 ` Evgeniy Polyakov
2006-08-07 7:28 ` Herbert Xu
2006-08-07 7:31 ` Evgeniy Polyakov
2006-08-07 7:39 ` Herbert Xu
2006-08-08 0:09 ` Jesse Brandeburg
2006-08-08 0:41 ` David Miller [this message]
2006-08-08 5:24 ` Evgeniy Polyakov
2006-08-08 5:41 ` Herbert Xu
2006-08-08 5:55 ` Evgeniy Polyakov
2006-08-07 6:29 ` Herbert Xu
2006-08-07 6:36 ` Evgeniy Polyakov
2006-08-07 6:42 ` Herbert Xu
2006-08-07 8:05 ` Eric Dumazet
2006-08-07 8:14 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060807.174142.88474584.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chris.leech@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=jesse.brandeburg@gmail.com \
--cc=jesse.brandeburg@intel.com \
--cc=johnpol@2ka.mipt.ru \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.