From: Andi Kleen <ak@suse.de>
To: "Jan Beulich" <jbeulich@novell.com>
Cc: anil.s.keshavamurthy@intel.com, "Andrew Morton" <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: notify_page_fault_chain
Date: Mon, 7 Aug 2006 15:36:40 +0200 [thread overview]
Message-ID: <200608071536.40303.ak@suse.de> (raw)
In-Reply-To: <44D75ACE.76E4.0078.0@novell.com>
On Monday 07 August 2006 15:22, Jan Beulich wrote:
> I just noticed this addition to i386 and x86-64, conditionalized upon CONFIG_KPROBES. May I ask what the motivation for
> this compatibility breaking change is?
It's normally policy to only care about in tree code regarding exports and hooks.
But also no policy without exceptions.
> Only performance?
Christopher L. complained about it taking too long on IA64 I think
(but that might have been some IA64 specific quirk)
I think I proposed to use a inline check of the chain and only then
call the external function, but that might not have been implemented
that way.
> I consider it already questionable to split out a specific
> fault from the general die notification (previous users of the functionality all of the sudden won't get notifications
> for one of the most crucial faults anymore), but entirely hiding the functionality (unavailable without CONFIG_KPROBES,
> and even with it not getting exported) is really odd.
You want to use it for your debugger?
-Andi
next prev parent reply other threads:[~2006-08-07 13:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-07 13:22 notify_page_fault_chain Jan Beulich
2006-08-07 13:36 ` Andi Kleen [this message]
2006-08-07 14:50 ` notify_page_fault_chain Jan Beulich
2006-08-07 14:55 ` notify_page_fault_chain Andi Kleen
2006-08-08 4:05 ` notify_page_fault_chain Keith Owens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608071536.40303.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.