* [PATCH 1 of 2] cpumask: use EXPORT_SYMBOL_GPL for new exports
@ 2006-08-08 3:25 ` Greg Banks
0 siblings, 0 replies; 8+ messages in thread
From: Greg Banks @ 2006-08-08 3:25 UTC (permalink / raw)
To: Andrew Morton
Cc: Linux NFS Mailing List, Zwane Mwaikambo,
Linux Kernel Mailing List
cpumask: use EXPORT_SYMBOL_GPL instead of EXPORT_SYMBOL to export
node_2_cpu_mask. Thanks to Zwane Mwaikambo for pointing this out.
Signed-off-by: Greg Banks <gnb@melbourne.sgi.com>
---
arch/i386/kernel/smpboot.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.18-rc2/arch/i386/kernel/smpboot.c
===================================================================
--- linux-2.6.18-rc2.orig/arch/i386/kernel/smpboot.c
+++ linux-2.6.18-rc2/arch/i386/kernel/smpboot.c
@@ -609,7 +609,7 @@ extern struct {
/* which logical CPUs are on which nodes */
cpumask_t node_2_cpu_mask[MAX_NUMNODES] __read_mostly =
{ [0 ... MAX_NUMNODES-1] = CPU_MASK_NONE };
-EXPORT_SYMBOL(node_2_cpu_mask);
+EXPORT_SYMBOL_GPL(node_2_cpu_mask);
/* which node each logical CPU is on */
int cpu_2_node[NR_CPUS] __read_mostly = { [0 ... NR_CPUS-1] = 0 };
EXPORT_SYMBOL(cpu_2_node);
Greg.
--
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
I don't speak for SGI.
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1 of 2] cpumask: use EXPORT_SYMBOL_GPL for new exports
@ 2006-08-08 3:25 ` Greg Banks
0 siblings, 0 replies; 8+ messages in thread
From: Greg Banks @ 2006-08-08 3:25 UTC (permalink / raw)
To: Andrew Morton
Cc: Zwane Mwaikambo, Linux NFS Mailing List,
Linux Kernel Mailing List
cpumask: use EXPORT_SYMBOL_GPL instead of EXPORT_SYMBOL to export
node_2_cpu_mask. Thanks to Zwane Mwaikambo for pointing this out.
Signed-off-by: Greg Banks <gnb@melbourne.sgi.com>
---
arch/i386/kernel/smpboot.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.18-rc2/arch/i386/kernel/smpboot.c
===================================================================
--- linux-2.6.18-rc2.orig/arch/i386/kernel/smpboot.c
+++ linux-2.6.18-rc2/arch/i386/kernel/smpboot.c
@@ -609,7 +609,7 @@ extern struct {
/* which logical CPUs are on which nodes */
cpumask_t node_2_cpu_mask[MAX_NUMNODES] __read_mostly =
{ [0 ... MAX_NUMNODES-1] = CPU_MASK_NONE };
-EXPORT_SYMBOL(node_2_cpu_mask);
+EXPORT_SYMBOL_GPL(node_2_cpu_mask);
/* which node each logical CPU is on */
int cpu_2_node[NR_CPUS] __read_mostly = { [0 ... NR_CPUS-1] = 0 };
EXPORT_SYMBOL(cpu_2_node);
Greg.
--
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
I don't speak for SGI.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1 of 2] cpumask: use EXPORT_SYMBOL_GPL for new exports
2006-08-08 3:25 ` Greg Banks
@ 2006-08-08 3:39 ` Andrew Morton
-1 siblings, 0 replies; 8+ messages in thread
From: Andrew Morton @ 2006-08-08 3:39 UTC (permalink / raw)
To: Greg Banks, Paul Jackson
Cc: Linux NFS Mailing List, Zwane Mwaikambo,
Linux Kernel Mailing List
On Tue, 08 Aug 2006 13:25:34 +1000
Greg Banks <gnb@melbourne.sgi.com> wrote:
> cpumask: use EXPORT_SYMBOL_GPL instead of EXPORT_SYMBOL to export
> node_2_cpu_mask. Thanks to Zwane Mwaikambo for pointing this out.
>
> Signed-off-by: Greg Banks <gnb@melbourne.sgi.com>
> ---
>
> arch/i386/kernel/smpboot.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6.18-rc2/arch/i386/kernel/smpboot.c
> ===================================================================
> --- linux-2.6.18-rc2.orig/arch/i386/kernel/smpboot.c
> +++ linux-2.6.18-rc2/arch/i386/kernel/smpboot.c
> @@ -609,7 +609,7 @@ extern struct {
> /* which logical CPUs are on which nodes */
> cpumask_t node_2_cpu_mask[MAX_NUMNODES] __read_mostly =
> { [0 ... MAX_NUMNODES-1] = CPU_MASK_NONE };
> -EXPORT_SYMBOL(node_2_cpu_mask);
> +EXPORT_SYMBOL_GPL(node_2_cpu_mask);
> /* which node each logical CPU is on */
> int cpu_2_node[NR_CPUS] __read_mostly = { [0 ... NR_CPUS-1] = 0 };
> EXPORT_SYMBOL(cpu_2_node);
All the existing exports in lib/cpumask.c are EXPORT_SYMBOL() so I'd be
inclined to make any new exports match that.
<edits the diffs>
OK?
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1 of 2] cpumask: use EXPORT_SYMBOL_GPL for new exports
@ 2006-08-08 3:39 ` Andrew Morton
0 siblings, 0 replies; 8+ messages in thread
From: Andrew Morton @ 2006-08-08 3:39 UTC (permalink / raw)
To: Greg Banks, Paul Jackson
Cc: Zwane Mwaikambo, Linux NFS Mailing List,
Linux Kernel Mailing List
On Tue, 08 Aug 2006 13:25:34 +1000
Greg Banks <gnb@melbourne.sgi.com> wrote:
> cpumask: use EXPORT_SYMBOL_GPL instead of EXPORT_SYMBOL to export
> node_2_cpu_mask. Thanks to Zwane Mwaikambo for pointing this out.
>
> Signed-off-by: Greg Banks <gnb@melbourne.sgi.com>
> ---
>
> arch/i386/kernel/smpboot.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6.18-rc2/arch/i386/kernel/smpboot.c
> ===================================================================
> --- linux-2.6.18-rc2.orig/arch/i386/kernel/smpboot.c
> +++ linux-2.6.18-rc2/arch/i386/kernel/smpboot.c
> @@ -609,7 +609,7 @@ extern struct {
> /* which logical CPUs are on which nodes */
> cpumask_t node_2_cpu_mask[MAX_NUMNODES] __read_mostly =
> { [0 ... MAX_NUMNODES-1] = CPU_MASK_NONE };
> -EXPORT_SYMBOL(node_2_cpu_mask);
> +EXPORT_SYMBOL_GPL(node_2_cpu_mask);
> /* which node each logical CPU is on */
> int cpu_2_node[NR_CPUS] __read_mostly = { [0 ... NR_CPUS-1] = 0 };
> EXPORT_SYMBOL(cpu_2_node);
All the existing exports in lib/cpumask.c are EXPORT_SYMBOL() so I'd be
inclined to make any new exports match that.
<edits the diffs>
OK?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1 of 2] cpumask: use EXPORT_SYMBOL_GPL for new exports
2006-08-08 3:39 ` Andrew Morton
@ 2006-08-08 3:40 ` Greg Banks
-1 siblings, 0 replies; 8+ messages in thread
From: Greg Banks @ 2006-08-08 3:40 UTC (permalink / raw)
To: Andrew Morton
Cc: Paul Jackson, Linux NFS Mailing List, Zwane Mwaikambo,
Linux Kernel Mailing List
On Tue, 2006-08-08 at 13:39, Andrew Morton wrote:
> All the existing exports in lib/cpumask.c are EXPORT_SYMBOL() so I'd be
> inclined to make any new exports match that.
>
> <edits the diffs>
>
> OK?
Fine by me.
Greg.
--
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
I don't speak for SGI.
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1 of 2] cpumask: use EXPORT_SYMBOL_GPL for new exports
@ 2006-08-08 3:40 ` Greg Banks
0 siblings, 0 replies; 8+ messages in thread
From: Greg Banks @ 2006-08-08 3:40 UTC (permalink / raw)
To: Andrew Morton
Cc: Paul Jackson, Zwane Mwaikambo, Linux NFS Mailing List,
Linux Kernel Mailing List
On Tue, 2006-08-08 at 13:39, Andrew Morton wrote:
> All the existing exports in lib/cpumask.c are EXPORT_SYMBOL() so I'd be
> inclined to make any new exports match that.
>
> <edits the diffs>
>
> OK?
Fine by me.
Greg.
--
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
I don't speak for SGI.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1 of 2] cpumask: use EXPORT_SYMBOL_GPL for new exports
2006-08-08 3:39 ` Andrew Morton
@ 2006-08-08 3:48 ` Paul Jackson
-1 siblings, 0 replies; 8+ messages in thread
From: Paul Jackson @ 2006-08-08 3:48 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, nfs, zwane, gnb
> All the existing exports in lib/cpumask.c are EXPORT_SYMBOL() so I'd be
> inclined to make any new exports match that.
>
> OK?
ok here too
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.925.600.0401
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1 of 2] cpumask: use EXPORT_SYMBOL_GPL for new exports
@ 2006-08-08 3:48 ` Paul Jackson
0 siblings, 0 replies; 8+ messages in thread
From: Paul Jackson @ 2006-08-08 3:48 UTC (permalink / raw)
To: Andrew Morton; +Cc: gnb, zwane, nfs, linux-kernel
> All the existing exports in lib/cpumask.c are EXPORT_SYMBOL() so I'd be
> inclined to make any new exports match that.
>
> OK?
ok here too
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.925.600.0401
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2006-08-08 3:48 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-08 3:25 [PATCH 1 of 2] cpumask: use EXPORT_SYMBOL_GPL for new exports Greg Banks
2006-08-08 3:25 ` Greg Banks
2006-08-08 3:39 ` Andrew Morton
2006-08-08 3:39 ` Andrew Morton
2006-08-08 3:40 ` Greg Banks
2006-08-08 3:40 ` Greg Banks
2006-08-08 3:48 ` Paul Jackson
2006-08-08 3:48 ` Paul Jackson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.