From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: netdev@vger.kernel.org
Subject: Re: [2/2] [IPV4]: Use network-order dport for all visible inet_lookup_*
Date: Tue, 08 Aug 2006 02:24:43 -0700 (PDT) [thread overview]
Message-ID: <20060808.022443.62664150.davem@davemloft.net> (raw)
In-Reply-To: <20060808084729.GA8085@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Tue, 8 Aug 2006 18:47:29 +1000
> So this patch changes all visible inet_lookup functions to take a
> dport and move all dport->hnum conversion inside them.
This isn't so nice because we will now byte-swap the port twice when
we try looking up a listening socket. Once for the established lookup
and once for the listening hash lookup.
It should be easy to do the byte-swap once at a higher level right?
next prev parent reply other threads:[~2006-08-08 9:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-08 8:46 [1/2] [IPV4]: Uninline inet_lookup_listener Herbert Xu
2006-08-08 8:47 ` [2/2] [IPV4]: Use network-order dport for all visible inet_lookup_* Herbert Xu
2006-08-08 9:24 ` David Miller [this message]
2006-08-08 11:11 ` Herbert Xu
2006-08-08 13:29 ` Christoph Hellwig
2006-08-08 13:40 ` Herbert Xu
2006-08-09 22:47 ` David Miller
2006-08-08 9:21 ` [1/2] [IPV4]: Uninline inet_lookup_listener David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060808.022443.62664150.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.